Re: [PATCH v3] qemu-sockets: fix unix socket path copy (again)

2021-09-07 Thread Stefan Reiter
Thanks for the patch, ran into the same issue here and was about to send my own ;) On 9/1/21 3:16 PM, Michael Tokarev wrote: Commit 4cfd970ec188558daa6214f26203fe553fb1e01f added an assert which ensures the path within an address of a unix socket returned from the kernel is at least one byte and

Re: [PATCH v3] qemu-sockets: fix unix socket path copy (again)

2021-09-06 Thread Philippe Mathieu-Daudé
On 9/6/21 1:39 PM, Michael Tokarev wrote: > 06.09.2021 14:34, Philippe Mathieu-Daudé wrote: > >> Certainly, but you could also pick the latest patches >> sent to qemu-trivial@ already reviewed ;) > > I haven't done this in years.. Not sure what that means... you are still listed as maintainer:

Re: [PATCH v3] qemu-sockets: fix unix socket path copy (again)

2021-09-06 Thread Michael Tokarev
06.09.2021 14:34, Philippe Mathieu-Daudé wrote: Certainly, but you could also pick the latest patches sent to qemu-trivial@ already reviewed ;) I haven't done this in years..

Re: [PATCH v3] qemu-sockets: fix unix socket path copy (again)

2021-09-06 Thread Philippe Mathieu-Daudé
On 9/6/21 1:25 PM, Michael Tokarev wrote: > 03.09.2021 19:04, Marc-André Lureau wrote: > [qemu-sockets.c unix path copy fix] > >> Daniel or Michael, or someone else queued this already? > > Nope, at least not me. I can send a pull request with a > single fix. Is it okay? Certainly, but you could

Re: [PATCH v3] qemu-sockets: fix unix socket path copy (again)

2021-09-06 Thread Michael Tokarev
03.09.2021 19:04, Marc-André Lureau wrote: [qemu-sockets.c unix path copy fix] Daniel or Michael, or someone else queued this already? Nope, at least not me. I can send a pull request with a single fix. Is it okay? /mjt

Re: [PATCH v3] qemu-sockets: fix unix socket path copy (again)

2021-09-03 Thread Marc-André Lureau
Hi On Wed, Sep 1, 2021 at 5:22 PM Michael Tokarev wrote: > Commit 4cfd970ec188558daa6214f26203fe553fb1e01f added an > assert which ensures the path within an address of a unix > socket returned from the kernel is at least one byte and > does not exceed sun_path buffer. Both of this constraints >

Re: [PATCH v3] qemu-sockets: fix unix socket path copy (again)

2021-09-01 Thread Marc-André Lureau
On Wed, Sep 1, 2021 at 5:16 PM Michael Tokarev wrote: > Commit 4cfd970ec188558daa6214f26203fe553fb1e01f added an > assert which ensures the path within an address of a unix > socket returned from the kernel is at least one byte and > does not exceed sun_path buffer. Both of this constraints > are

Re: [PATCH v3] qemu-sockets: fix unix socket path copy (again)

2021-09-01 Thread Daniel P . Berrangé
On Wed, Sep 01, 2021 at 04:16:24PM +0300, Michael Tokarev wrote: > Commit 4cfd970ec188558daa6214f26203fe553fb1e01f added an > assert which ensures the path within an address of a unix > socket returned from the kernel is at least one byte and > does not exceed sun_path buffer. Both of this constrai

[PATCH v3] qemu-sockets: fix unix socket path copy (again)

2021-09-01 Thread Michael Tokarev
Commit 4cfd970ec188558daa6214f26203fe553fb1e01f added an assert which ensures the path within an address of a unix socket returned from the kernel is at least one byte and does not exceed sun_path buffer. Both of this constraints are wrong: A unix socket can be unnamed, in this case the path is co