Re: [PATCH v3] multi-process: Initialize variables declared with g_auto*

2021-04-26 Thread Stefan Hajnoczi
On Tue, Apr 06, 2021 at 10:00:03PM +0800, Zenghui Yu wrote: > [+Stefan] > > On 2021/3/12 19:21, Zenghui Yu wrote: > > Quote docs/devel/style.rst (section "Automatic memory deallocation"): > > > > * Variables declared with g_auto* MUST always be initialized, > >otherwise the cleanup function w

Re: [PATCH v3] multi-process: Initialize variables declared with g_auto*

2021-04-06 Thread Zenghui Yu
[+Stefan] On 2021/3/12 19:21, Zenghui Yu wrote: Quote docs/devel/style.rst (section "Automatic memory deallocation"): * Variables declared with g_auto* MUST always be initialized, otherwise the cleanup function will use uninitialized stack memory Initialize @name properly to get rid of the

Re: [PATCH v3] multi-process: Initialize variables declared with g_auto*

2021-03-14 Thread Miroslav Rezanina
On Mon, Mar 15, 2021 at 02:20:10PM +0800, Zenghui Yu wrote: > On 2021/3/15 13:48, Miroslav Rezanina wrote: > > Missing declaration without initialization in hw/s390x/s390-pci-vfio.c > > othwerwise correct. Will you send v4 with missing initialization or > > should I send then as another patch? > >

Re: [PATCH v3] multi-process: Initialize variables declared with g_auto*

2021-03-14 Thread Zenghui Yu
On 2021/3/15 13:48, Miroslav Rezanina wrote: Missing declaration without initialization in hw/s390x/s390-pci-vfio.c othwerwise correct. Will you send v4 with missing initialization or should I send then as another patch? I'd prefer the latter so that subsystem maintainers can take the separate

Re: [PATCH v3] multi-process: Initialize variables declared with g_auto*

2021-03-14 Thread Miroslav Rezanina
On Fri, Mar 12, 2021 at 07:21:43PM +0800, Zenghui Yu wrote: > Quote docs/devel/style.rst (section "Automatic memory deallocation"): > > * Variables declared with g_auto* MUST always be initialized, > otherwise the cleanup function will use uninitialized stack memory > > Initialize @name properl

Re: [PATCH v3] multi-process: Initialize variables declared with g_auto*

2021-03-12 Thread Philippe Mathieu-Daudé
Cc'ing Miroslav On 3/12/21 12:21 PM, Zenghui Yu wrote: > Quote docs/devel/style.rst (section "Automatic memory deallocation"): > > * Variables declared with g_auto* MUST always be initialized, > otherwise the cleanup function will use uninitialized stack memory > > Initialize @name properly to

[PATCH v3] multi-process: Initialize variables declared with g_auto*

2021-03-12 Thread Zenghui Yu
Quote docs/devel/style.rst (section "Automatic memory deallocation"): * Variables declared with g_auto* MUST always be initialized, otherwise the cleanup function will use uninitialized stack memory Initialize @name properly to get rid of the compilation error (using gcc-7.3.0 on CentOS): ../h