Re: [PATCH v3] kvm: replace fprintf with error_report/printf() in kvm_init()

2024-08-27 Thread Markus Armbruster
Ani Sinha writes: >> On 27 Aug 2024, at 12:00 PM, Markus Armbruster wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> Hi Ani, >>> >>> On 9/8/24 08:49, Ani Sinha wrote: error_report() is more appropriate for error situations. Replace fprintf with error_report. Cosmetic. No fu

Re: [PATCH v3] kvm: replace fprintf with error_report/printf() in kvm_init()

2024-08-27 Thread Ani Sinha
> On 27 Aug 2024, at 12:00 PM, Markus Armbruster wrote: > > Philippe Mathieu-Daudé writes: > >> Hi Ani, >> >> On 9/8/24 08:49, Ani Sinha wrote: >>> error_report() is more appropriate for error situations. Replace fprintf >>> with >>> error_report. Cosmetic. No functional change. >>> CC: qe

Re: [PATCH v3] kvm: replace fprintf with error_report/printf() in kvm_init()

2024-08-26 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Hi Ani, > > On 9/8/24 08:49, Ani Sinha wrote: >> error_report() is more appropriate for error situations. Replace fprintf with >> error_report. Cosmetic. No functional change. >> CC: qemu-triv...@nongnu.org >> CC: zhao1@intel.com > > (Pointless to carry Cc lin

Re: [PATCH v3] kvm: replace fprintf with error_report/printf() in kvm_init()

2024-08-20 Thread Ani Sinha
> On 16 Aug 2024, at 11:51 AM, Philippe Mathieu-Daudé wrote: > > On 12/8/24 11:59, Ani Sinha wrote: >> On Mon, 12 Aug, 2024, 3:23 pm Ani Sinha, > > wrote: >>On Fri, Aug 9, 2024 at 2:06 PM Philippe Mathieu-Daudé >>mailto:phi...@linaro.org>> wrote: >> > >>

Re: [PATCH v3] kvm: replace fprintf with error_report/printf() in kvm_init()

2024-08-15 Thread Philippe Mathieu-Daudé
On 12/8/24 11:59, Ani Sinha wrote: On Mon, 12 Aug, 2024, 3:23 pm Ani Sinha, > wrote: On Fri, Aug 9, 2024 at 2:06 PM Philippe Mathieu-Daudé mailto:phi...@linaro.org>> wrote: > > Hi Ani, > > On 9/8/24 08:49, Ani Sinha wrote: > > error

Re: [PATCH v3] kvm: replace fprintf with error_report/printf() in kvm_init()

2024-08-12 Thread Ani Sinha
On Mon, 12 Aug, 2024, 3:23 pm Ani Sinha, wrote: > On Fri, Aug 9, 2024 at 2:06 PM Philippe Mathieu-Daudé > wrote: > > > > Hi Ani, > > > > On 9/8/24 08:49, Ani Sinha wrote: > > > error_report() is more appropriate for error situations. Replace > fprintf with > > > error_report. Cosmetic. No functi

Re: [PATCH v3] kvm: replace fprintf with error_report/printf() in kvm_init()

2024-08-12 Thread Ani Sinha
On Fri, Aug 9, 2024 at 2:06 PM Philippe Mathieu-Daudé wrote: > > Hi Ani, > > On 9/8/24 08:49, Ani Sinha wrote: > > error_report() is more appropriate for error situations. Replace fprintf > > with > > error_report. Cosmetic. No functional change. > > > > CC: qemu-triv...@nongnu.org > > CC: zhao1.

Re: [PATCH v3] kvm: replace fprintf with error_report/printf() in kvm_init()

2024-08-09 Thread Philippe Mathieu-Daudé
Hi Ani, On 9/8/24 08:49, Ani Sinha wrote: error_report() is more appropriate for error situations. Replace fprintf with error_report. Cosmetic. No functional change. CC: qemu-triv...@nongnu.org CC: zhao1@intel.com (Pointless to carry Cc line when patch is already reviewed next line) Rev

[PATCH v3] kvm: replace fprintf with error_report/printf() in kvm_init()

2024-08-08 Thread Ani Sinha
error_report() is more appropriate for error situations. Replace fprintf with error_report. Cosmetic. No functional change. CC: qemu-triv...@nongnu.org CC: zhao1@intel.com Reviewed-by: Zhao Liu Signed-off-by: Ani Sinha --- accel/kvm/kvm-all.c | 40 ++-- 1