Re: [PATCH v3] hw/sensor: Add lsm303dlhc magnetometer device

2021-09-28 Thread Peter Maydell
On Tue, 28 Sept 2021 at 11:36, Kevin Townsend wrote: > > Hi Peter, > > On Mon, 27 Sept 2021 at 18:39, Peter Maydell wrote: >> >> I thought we'd agreed to implement the whole of the auto-increment >> logic, not just for specific registers ? > > > Thanks again for the feedback. Dealing with one reg

Re: [PATCH v3] hw/sensor: Add lsm303dlhc magnetometer device

2021-09-28 Thread Kevin Townsend
Hi Peter, On Mon, 27 Sept 2021 at 18:39, Peter Maydell wrote: > I thought we'd agreed to implement the whole of the auto-increment > logic, not just for specific registers ? > Thanks again for the feedback. Dealing with one register value at a time (versus a buffer of response values) does simp

Re: [PATCH v3] hw/sensor: Add lsm303dlhc magnetometer device

2021-09-27 Thread Peter Maydell
On Mon, 27 Sept 2021 at 18:47, Kevin Townsend wrote: > > Hi Peter, > > Thanks for the updated review. > > On Mon, 27 Sept 2021 at 18:39, Peter Maydell wrote: >> >> I thought we'd agreed to implement the whole of the auto-increment >> logic, not just for specific registers ? > > > The problem I ha

Re: [PATCH v3] hw/sensor: Add lsm303dlhc magnetometer device

2021-09-27 Thread Kevin Townsend
Hi Peter, Thanks for the updated review. On Mon, 27 Sept 2021 at 18:39, Peter Maydell wrote: > I thought we'd agreed to implement the whole of the auto-increment > logic, not just for specific registers ? > The problem I have here is ... how many bytes are we willing to buffer? There's no reas

Re: [PATCH v3] hw/sensor: Add lsm303dlhc magnetometer device

2021-09-27 Thread Peter Maydell
On Tue, 21 Sept 2021 at 10:41, Kevin Townsend wrote: > > This commit adds emulation of the magnetometer on the LSM303DLHC. > It allows the magnetometer's X, Y and Z outputs to be set via the > mag-x, mag-y and mag-z properties, as well as the 12-bit > temperature output via the temperature propert

[PATCH v3] hw/sensor: Add lsm303dlhc magnetometer device

2021-09-21 Thread Kevin Townsend
This commit adds emulation of the magnetometer on the LSM303DLHC. It allows the magnetometer's X, Y and Z outputs to be set via the mag-x, mag-y and mag-z properties, as well as the 12-bit temperature output via the temperature property. Signed-off-by: Kevin Townsend --- hw/sensor/Kconfig