Re: [PATCH v3] failover: fix unplug pending detection

2021-11-18 Thread Ani Sinha
On Thu, Nov 18, 2021 at 2:45 PM Laurent Vivier wrote: > > On 18/10/2021 10:27, Michael S. Tsirkin wrote: > > On Mon, Oct 18, 2021 at 09:19:16AM +0200, Laurent Vivier wrote: > >> Hi, > >> > >> I don't understand if there are some issues > > > > Gerd did identify some issues, you felt they aren't re

Re: [PATCH v3] failover: fix unplug pending detection

2021-11-18 Thread Laurent Vivier
On 18/10/2021 10:27, Michael S. Tsirkin wrote: On Mon, Oct 18, 2021 at 09:19:16AM +0200, Laurent Vivier wrote: Hi, I don't understand if there are some issues Gerd did identify some issues, you felt they aren't related to the patch and need to be addressed separately. Gerd posted patches tha

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-18 Thread Michael S. Tsirkin
On Mon, Oct 18, 2021 at 09:19:16AM +0200, Laurent Vivier wrote: > Hi, > > I don't understand if there are some issues Gerd did identify some issues, you felt they aren't related to the patch and need to be addressed separately. Gerd posted patches that are supposed to address them since. "try im

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-18 Thread Laurent Vivier
Hi, I don't understand if there are some issues to address to have this patch merged? Thanks, Laurent On 01/10/2021 10:25, Laurent Vivier wrote: Failover needs to detect the end of the PCI unplug to start migration after the VFIO card has been unplugged. To do that, a flag is set in pcie_cap

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-05 Thread Ani Sinha
On Tue, 5 Oct 2021, Laurent Vivier wrote: > On 05/10/2021 17:14, Michael S. Tsirkin wrote: > > On Fri, Oct 01, 2021 at 10:25:02AM +0200, Laurent Vivier wrote: > > > Failover needs to detect the end of the PCI unplug to start migration > > > after the VFIO card has been unplugged. > > > > > > To

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-05 Thread Laurent Vivier
On 05/10/2021 17:14, Michael S. Tsirkin wrote: On Fri, Oct 01, 2021 at 10:25:02AM +0200, Laurent Vivier wrote: Failover needs to detect the end of the PCI unplug to start migration after the VFIO card has been unplugged. To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset i

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-05 Thread Michael S. Tsirkin
On Fri, Oct 01, 2021 at 10:25:02AM +0200, Laurent Vivier wrote: > Failover needs to detect the end of the PCI unplug to start migration > after the VFIO card has been unplugged. > > To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in > pcie_unplug_device(). > > But since >

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-01 Thread Ani Sinha
On Fri, 1 Oct 2021, Gerd Hoffmann wrote: > Hi, > > > > So, in case the first time didn't work (for example due to the guest not > > > listening because grub just doesn't do that), you can try a second time > > > once the linux kernel is up'n'running. > > > > > > I suspect this patch will brea

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-01 Thread Ani Sinha
On Fri, Oct 1, 2021 at 18:19 Gerd Hoffmann wrote: > Hi, > > > > So, in case the first time didn't work (for example due to the guest > not > > > listening because grub just doesn't do that), you can try a second time > > > once the linux kernel is up'n'running. > > > > > > I suspect this patch

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-01 Thread Gerd Hoffmann
Hi, > > So, in case the first time didn't work (for example due to the guest not > > listening because grub just doesn't do that), you can try a second time > > once the linux kernel is up'n'running. > > > > I suspect this patch will break that (didn't actually test though). > > I think the so

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-01 Thread Laurent Vivier
On 01/10/2021 12:45, Gerd Hoffmann wrote: On Fri, Oct 01, 2021 at 10:25:02AM +0200, Laurent Vivier wrote: Failover needs to detect the end of the PCI unplug to start migration after the VFIO card has been unplugged. To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in pci

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-01 Thread Daniel P . Berrangé
On Fri, Oct 01, 2021 at 12:45:14PM +0200, Gerd Hoffmann wrote: > On Fri, Oct 01, 2021 at 10:25:02AM +0200, Laurent Vivier wrote: > > Failover needs to detect the end of the PCI unplug to start migration > > after the VFIO card has been unplugged. > > > > To do that, a flag is set in pcie_cap_slot_

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-01 Thread Gerd Hoffmann
On Fri, Oct 01, 2021 at 10:25:02AM +0200, Laurent Vivier wrote: > Failover needs to detect the end of the PCI unplug to start migration > after the VFIO card has been unplugged. > > To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in > pcie_unplug_device(). > +/* > +

[PATCH v3] failover: fix unplug pending detection

2021-10-01 Thread Laurent Vivier
Failover needs to detect the end of the PCI unplug to start migration after the VFIO card has been unplugged. To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in pcie_unplug_device(). But since 17858a169508 ("hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35") we h