Re: [PATCH v3] block/gluster: correctly set max_pdiscard

2022-05-30 Thread Kevin Wolf
Am 20.05.2022 um 09:59 hat Fabian Ebner geschrieben: > On 64-bit platforms, assigning SIZE_MAX to the int64_t max_pdiscard > results in a negative value, and the following assertion would trigger > down the line (it's not the same max_pdiscard, but computed from the > other one): > qemu-system-x86_

Re: [PATCH v3] block/gluster: correctly set max_pdiscard

2022-05-27 Thread Vladimir Sementsov-Ogievskiy
On 5/20/22 10:59, Fabian Ebner wrote: On 64-bit platforms, assigning SIZE_MAX to the int64_t max_pdiscard results in a negative value, and the following assertion would trigger Oops. Good catch! down the line (it's not the same max_pdiscard, but computed from the other one): qemu-system-x86_6

Re: [PATCH v3] block/gluster: correctly set max_pdiscard

2022-05-25 Thread Stefano Garzarella
On Fri, May 20, 2022 at 09:59:22AM +0200, Fabian Ebner wrote: On 64-bit platforms, assigning SIZE_MAX to the int64_t max_pdiscard results in a negative value, and the following assertion would trigger down the line (it's not the same max_pdiscard, but computed from the other one): qemu-system-x86

Re: [PATCH v3] block/gluster: correctly set max_pdiscard

2022-05-24 Thread Eric Blake
On Fri, May 20, 2022 at 09:59:22AM +0200, Fabian Ebner wrote: > On 64-bit platforms, assigning SIZE_MAX to the int64_t max_pdiscard > results in a negative value, and the following assertion would trigger > down the line (it's not the same max_pdiscard, but computed from the > other one): > qemu-sy

[PATCH v3] block/gluster: correctly set max_pdiscard

2022-05-20 Thread Fabian Ebner
On 64-bit platforms, assigning SIZE_MAX to the int64_t max_pdiscard results in a negative value, and the following assertion would trigger down the line (it's not the same max_pdiscard, but computed from the other one): qemu-system-x86_64: ../block/io.c:3166: bdrv_co_pdiscard: Assertion `max_pdisca