Re: [PATCH v26 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro

2020-05-11 Thread gengdongjiu
On 2020/5/12 3:41, Igor Mammedov wrote: > for future, adding RESEND doesn't make sence here. If you change patches then > just bump version. Igor, Thanks for the reminder, Just now I submitted a new patchset version to avoid this confusion.

Re: [PATCH v26 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro

2020-05-11 Thread Igor Mammedov
On Mon, 11 May 2020 22:05:28 +0800 gengdongjiu wrote: > >> +    (node3), (node4), (node5) } > >> + > >>   #define UUID_FMT "%02hhx%02hhx%02hhx%02hhx-" \ > >>    "%02hhx%02hhx-%02hhx%02hhx-" \ > >>    "%02hhx%02hhx-" \ > >> diff --git a/slirp b/slirp > >> index 2faa

Re: [PATCH v26 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro

2020-05-11 Thread gengdongjiu
>> +    (node3), (node4), (node5) } >> + >>   #define UUID_FMT "%02hhx%02hhx%02hhx%02hhx-" \ >>    "%02hhx%02hhx-%02hhx%02hhx-" \ >>    "%02hhx%02hhx-" \ >> diff --git a/slirp b/slirp >> index 2faae0f..55ab21c 16 >> --- a/slirp >> +++ b/slirp >> @@ -1 +1 @@ >> -S

Re: [PATCH v26 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro

2020-05-11 Thread gengdongjiu
On 2020/5/11 20:29, Philippe Mathieu-Daudé wrote: >> @@ -1 +1 @@ >> -Subproject commit 2faae0f778f818fadc873308f983289df697eb93 >> +Subproject commit 55ab21c9a36852915b81f1b41ebaf3b6509dd8ba > > The SLiRP submodule change is certainly unrelated. Thanks Philippe's review and comments. I submitted

Re: [PATCH v26 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro

2020-05-11 Thread Philippe Mathieu-Daudé
On 5/7/20 3:41 PM, Dongjiu Geng wrote: The little end UUID is used in many places, so make NVDIMM_UUID_LE to a common macro to convert the UUID to a little end array. Reviewed-by: Xiang Zheng Signed-off-by: Dongjiu Geng --- Change since v25: 1. Address Peter's comments to add a proper doc-comm

[PATCH v26 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro

2020-05-07 Thread Dongjiu Geng
The little end UUID is used in many places, so make NVDIMM_UUID_LE to a common macro to convert the UUID to a little end array. Reviewed-by: Xiang Zheng Signed-off-by: Dongjiu Geng --- Change since v25: 1. Address Peter's comments to add a proper doc-comment comment for UUID_LE macros. --- h