Re: [PATCH v2 for-8.0] hw/rtc/mc146818rtc: Make this rtc device target independent

2022-12-11 Thread Thomas Huth
On 10/12/2022 14.48, Mark Cave-Ayland wrote: On 09/12/2022 11:15, Thomas Huth wrote: The only reason for this code being target dependent is the apic-related code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather simple, we can easily move them into a new, separate file (a

Re: [PATCH v2 for-8.0] hw/rtc/mc146818rtc: Make this rtc device target independent

2022-12-11 Thread Bernhard Beschow
Am 10. Dezember 2022 13:48:00 UTC schrieb Mark Cave-Ayland : >On 09/12/2022 11:15, Thomas Huth wrote: > >> The only reason for this code being target dependent is the apic-related >> code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather >> simple, we can easily move them

Re: [PATCH v2 for-8.0] hw/rtc/mc146818rtc: Make this rtc device target independent

2022-12-10 Thread Mark Cave-Ayland
On 09/12/2022 11:15, Thomas Huth wrote: The only reason for this code being target dependent is the apic-related code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather simple, we can easily move them into a new, separate file (apic_irqcount.c) which will always be compiled

Re: [PATCH v2 for-8.0] hw/rtc/mc146818rtc: Make this rtc device target independent

2022-12-09 Thread Philippe Mathieu-Daudé
On 9/12/22 12:15, Thomas Huth wrote: The only reason for this code being target dependent is the apic-related code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather simple, we can easily move them into a new, separate file (apic_irqcount.c) which will always be compiled and

[PATCH v2 for-8.0] hw/rtc/mc146818rtc: Make this rtc device target independent

2022-12-09 Thread Thomas Huth
The only reason for this code being target dependent is the apic-related code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather simple, we can easily move them into a new, separate file (apic_irqcount.c) which will always be compiled and linked if either APIC or the mc146818 d