Re: [PATCH v2 9/9] dump: Consolidate elf note function

2022-03-11 Thread Richard Henderson
On 3/10/22 03:08, Janosch Frank wrote: +static void write_elf_notes(DumpState *s, Error **errp) +{ +ERRP_GUARD(); + +if (dump_is_64bit(s)) { +write_elf64_notes(fd_write_vmcore, s, errp); +} else { +write_elf32_notes(fd_write_vmcore, s, errp); +} +if (*errp) { +

[PATCH v2 9/9] dump: Consolidate elf note function

2022-03-10 Thread Janosch Frank
Just like with the other write functions let's move the 32/64 bit elf handling to a function to improve readability. Signed-off-by: Janosch Frank --- dump/dump.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/dump/dump.c b/dump/dump.c index 5542adf7b