Re: [PATCH v2 7/7] qapi: More complex uses of QAPI_LIST_APPEND

2020-12-04 Thread Eric Blake
On 11/19/20 2:50 AM, Markus Armbruster wrote: > Eric Blake writes: > >> These cases require a bit more thought to review; in each case, the >> code was appending to a list, but not with a FOOList **tail variable. >> +++ b/hw/core/machine-qmp-cmds.c > [...] >> @@ -294,41 +281,31 @@ void qmp_set_n

Re: [PATCH v2 7/7] qapi: More complex uses of QAPI_LIST_APPEND

2020-11-19 Thread Markus Armbruster
Eric Blake writes: > These cases require a bit more thought to review; in each case, the > code was appending to a list, but not with a FOOList **tail variable. > > Signed-off-by: Eric Blake > --- > block/gluster.c| 13 +--- > block/qapi.c | 14 + > dump/dump.c

Re: [PATCH v2 7/7] qapi: More complex uses of QAPI_LIST_APPEND

2020-11-16 Thread Eric Blake
On 11/13/20 1:39 PM, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: >> These cases require a bit more thought to review; in each case, the >> code was appending to a list, but not with a FOOList **tail variable. >> >> Signed-off-by: Eric Blake >> --- > > > >> +++ b/mo

Re: [PATCH v2 7/7] qapi: More complex uses of QAPI_LIST_APPEND

2020-11-13 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > These cases require a bit more thought to review; in each case, the > code was appending to a list, but not with a FOOList **tail variable. > > Signed-off-by: Eric Blake > --- > block/gluster.c| 13 +--- > block/qapi.c | 14 +-

[PATCH v2 7/7] qapi: More complex uses of QAPI_LIST_APPEND

2020-11-12 Thread Eric Blake
These cases require a bit more thought to review; in each case, the code was appending to a list, but not with a FOOList **tail variable. Signed-off-by: Eric Blake --- block/gluster.c| 13 +--- block/qapi.c | 14 + dump/dump.c| 22 ++- hw/core