Re: [PATCH v2 6/7] block/block-copy: reduce intersecting request lock

2020-02-20 Thread Max Reitz
On 20.02.20 08:21, Vladimir Sementsov-Ogievskiy wrote: > 17.02.2020 16:38, Max Reitz wrote: >> On 27.11.19 19:08, Vladimir Sementsov-Ogievskiy wrote: [...] >>> +    if (!block_copy_wait_one(s, start, bytes)) { >>> +    /* No dirty bits and nothing to wait: the whole request >>> is don

Re: [PATCH v2 6/7] block/block-copy: reduce intersecting request lock

2020-02-19 Thread Vladimir Sementsov-Ogievskiy
17.02.2020 16:38, Max Reitz wrote: On 27.11.19 19:08, Vladimir Sementsov-Ogievskiy wrote: Currently, block_copy operation lock the whole requested region. But there is no reason to lock clusters, which are already copied, it will disturb other parallel block_copy requests for no reason. Let's i

Re: [PATCH v2 6/7] block/block-copy: reduce intersecting request lock

2020-02-17 Thread Max Reitz
On 27.11.19 19:08, Vladimir Sementsov-Ogievskiy wrote: > Currently, block_copy operation lock the whole requested region. But > there is no reason to lock clusters, which are already copied, it will > disturb other parallel block_copy requests for no reason. > > Let's instead do the following: >

Re: [PATCH v2 6/7] block/block-copy: reduce intersecting request lock

2020-01-30 Thread Andrey Shinkevich
On 30/01/2020 20:09, Vladimir Sementsov-Ogievskiy wrote: 30.01.2020 19:24, Andrey Shinkevich wrote: On 30/01/2020 16:45, Vladimir Sementsov-Ogievskiy wrote: 29.01.2020 23:05, Andrey Shinkevich wrote: On 27/11/2019 21:08, Vladimir Sementsov-Ogievskiy wrote: Currently, block_copy operati

Re: [PATCH v2 6/7] block/block-copy: reduce intersecting request lock

2020-01-30 Thread Vladimir Sementsov-Ogievskiy
30.01.2020 19:24, Andrey Shinkevich wrote: On 30/01/2020 16:45, Vladimir Sementsov-Ogievskiy wrote: 29.01.2020 23:05, Andrey Shinkevich wrote: On 27/11/2019 21:08, Vladimir Sementsov-Ogievskiy wrote: Currently, block_copy operation lock the whole requested region. But there is no reason to

Re: [PATCH v2 6/7] block/block-copy: reduce intersecting request lock

2020-01-30 Thread Andrey Shinkevich
On 30/01/2020 16:45, Vladimir Sementsov-Ogievskiy wrote: 29.01.2020 23:05, Andrey Shinkevich wrote: On 27/11/2019 21:08, Vladimir Sementsov-Ogievskiy wrote: Currently, block_copy operation lock the whole requested region. But there is no reason to lock clusters, which are already copied, i

Re: [PATCH v2 6/7] block/block-copy: reduce intersecting request lock

2020-01-30 Thread Vladimir Sementsov-Ogievskiy
30.01.2020 18:53, Andrey Shinkevich wrote: On 27/11/2019 21:08, Vladimir Sementsov-Ogievskiy wrote: Currently, block_copy operation lock the whole requested region. But there is no reason to lock clusters, which are already copied, it will disturb other parallel block_copy requests for no reas

Re: [PATCH v2 6/7] block/block-copy: reduce intersecting request lock

2020-01-30 Thread Andrey Shinkevich
On 27/11/2019 21:08, Vladimir Sementsov-Ogievskiy wrote: Currently, block_copy operation lock the whole requested region. But there is no reason to lock clusters, which are already copied, it will disturb other parallel block_copy requests for no reason. Let's instead do the following: Lock

Re: [PATCH v2 6/7] block/block-copy: reduce intersecting request lock

2020-01-30 Thread Vladimir Sementsov-Ogievskiy
29.01.2020 23:05, Andrey Shinkevich wrote: On 27/11/2019 21:08, Vladimir Sementsov-Ogievskiy wrote: Currently, block_copy operation lock the whole requested region. But there is no reason to lock clusters, which are already copied, it will disturb other parallel block_copy requests for no reas

Re: [PATCH v2 6/7] block/block-copy: reduce intersecting request lock

2020-01-29 Thread Andrey Shinkevich
On 27/11/2019 21:08, Vladimir Sementsov-Ogievskiy wrote: > Currently, block_copy operation lock the whole requested region. But > there is no reason to lock clusters, which are already copied, it will > disturb other parallel block_copy requests for no reason. > > Let's instead do the following:

[PATCH v2 6/7] block/block-copy: reduce intersecting request lock

2019-11-27 Thread Vladimir Sementsov-Ogievskiy
Currently, block_copy operation lock the whole requested region. But there is no reason to lock clusters, which are already copied, it will disturb other parallel block_copy requests for no reason. Let's instead do the following: Lock only sub-region, which we are going to operate on. Then, after