Re: [PATCH v2 6/6] qemu-option: warn for short-form boolean options

2020-11-10 Thread Markus Armbruster
Paolo Bonzini writes: > Il lun 9 nov 2020, 22:19 Markus Armbruster ha scritto: > >> This function now warns, except for "help" and "?". The exception >> applies even when we treat "help" and "?" as sugar for "help=on" and >> "?=on" because opts_accepts_any(). >> > > Right, because again help_wa

Re: [PATCH v2 6/6] qemu-option: warn for short-form boolean options

2020-11-09 Thread Paolo Bonzini
Il lun 9 nov 2020, 22:19 Markus Armbruster ha scritto: > This function now warns, except for "help" and "?". The exception > applies even when we treat "help" and "?" as sugar for "help=on" and > "?=on" because opts_accepts_any(). > Right, because again help_wanted will be false for non-validat

Re: [PATCH v2 6/6] qemu-option: warn for short-form boolean options

2020-11-09 Thread Markus Armbruster
Paolo Bonzini writes: > Options such as "server" or "nowait", that are commonly found in -chardev, > are sugar for "server=on" and "wait=off". This is quite surprising and > also does not have any notion of typing attached. It is even possible to > do "-device e1000,noid" and get a device with

[PATCH v2 6/6] qemu-option: warn for short-form boolean options

2020-11-09 Thread Paolo Bonzini
Options such as "server" or "nowait", that are commonly found in -chardev, are sugar for "server=on" and "wait=off". This is quite surprising and also does not have any notion of typing attached. It is even possible to do "-device e1000,noid" and get a device with "id=off". Deprecate it and prin