Re: [PATCH v2 5/9] tcg: add const hints for code pointers

2020-10-19 Thread Richard Henderson
On 10/19/20 4:36 PM, Joelle van Dyne wrote: > Seems like I missed a few. Sorry about that. Will fix. I'll keep looking, Just In Case. ;-) >> s->code_gen_epilogue = tb_ret_addr = s->code_ptr; In this case, just splitting the chained assignment to two statements is sufficient to fix. r~

Re: [PATCH v2 5/9] tcg: add const hints for code pointers

2020-10-19 Thread Joelle van Dyne
Seems like I missed a few. Sorry about that. Will fix. -j On Mon, Oct 19, 2020 at 4:27 PM Richard Henderson wrote: > > On 10/18/20 6:39 PM, Joelle van Dyne wrote: > > From: osy > > > > We will introduce mirror mapping for JIT segment with separate RX and RW > > access. Adding 'const' hints will

Re: [PATCH v2 5/9] tcg: add const hints for code pointers

2020-10-19 Thread Richard Henderson
On 10/18/20 6:39 PM, Joelle van Dyne wrote: > From: osy > > We will introduce mirror mapping for JIT segment with separate RX and RW > access. Adding 'const' hints will make it easier to identify read-only > accesses and allow us to easier catch bugs at compile time in the future. > > Signed-off

Re: [PATCH v2 5/9] tcg: add const hints for code pointers

2020-10-19 Thread Joelle van Dyne
You can --author "Joelle van Dyne " -j On Mon, Oct 19, 2020 at 4:19 PM Richard Henderson wrote: > > On 10/18/20 6:39 PM, Joelle van Dyne wrote: > > From: osy > > > > We will introduce mirror mapping for JIT segment with separate RX and RW > > access. Adding 'const' hints will make it easier to

Re: [PATCH v2 5/9] tcg: add const hints for code pointers

2020-10-19 Thread Richard Henderson
On 10/18/20 6:39 PM, Joelle van Dyne wrote: > From: osy > > We will introduce mirror mapping for JIT segment with separate RX and RW > access. Adding 'const' hints will make it easier to identify read-only > accesses and allow us to easier catch bugs at compile time in the future. > > Signed-off

[PATCH v2 5/9] tcg: add const hints for code pointers

2020-10-18 Thread Joelle van Dyne
From: osy We will introduce mirror mapping for JIT segment with separate RX and RW access. Adding 'const' hints will make it easier to identify read-only accesses and allow us to easier catch bugs at compile time in the future. Signed-off-by: Joelle van Dyne --- include/tcg/tcg.h|