Re: [PATCH v2 5/6] hw/input/stellaris_input: Convert to qdev

2023-10-31 Thread Peter Maydell
On Tue, 31 Oct 2023 at 14:55, Philippe Mathieu-Daudé wrote: > > On 31/10/23 15:05, Peter Maydell wrote: > > On Tue, 31 Oct 2023 at 13:55, Peter Maydell > > wrote: > >> > >> On Mon, 30 Oct 2023 at 20:38, Mark Cave-Ayland > >> wrote: > >>> > >>> On 30/10/2023 11:48, Peter Maydell wrote: > >>> Is

Re: [PATCH v2 5/6] hw/input/stellaris_input: Convert to qdev

2023-10-31 Thread Philippe Mathieu-Daudé
On 31/10/23 15:05, Peter Maydell wrote: On Tue, 31 Oct 2023 at 13:55, Peter Maydell wrote: On Mon, 30 Oct 2023 at 20:38, Mark Cave-Ayland wrote: On 30/10/2023 11:48, Peter Maydell wrote: Is it worth converting this to use DEFINE_TYPES() during the conversion? I know Phil has considered som

Re: [PATCH v2 5/6] hw/input/stellaris_input: Convert to qdev

2023-10-31 Thread Peter Maydell
On Tue, 31 Oct 2023 at 13:55, Peter Maydell wrote: > > On Mon, 30 Oct 2023 at 20:38, Mark Cave-Ayland > wrote: > > > > On 30/10/2023 11:48, Peter Maydell wrote: > > Is it worth converting this to use DEFINE_TYPES() during the conversion? I > > know Phil > > has considered some automation to remo

Re: [PATCH v2 5/6] hw/input/stellaris_input: Convert to qdev

2023-10-31 Thread Peter Maydell
On Mon, 30 Oct 2023 at 20:38, Mark Cave-Ayland wrote: > > On 30/10/2023 11:48, Peter Maydell wrote: > > > Convert the hw/input/stellaris_input device to qdev. > > > > The interface uses an array property for the board to specify the > > keycodes to use, so the s->keycodes memory is now allocated b

Re: [PATCH v2 5/6] hw/input/stellaris_input: Convert to qdev

2023-10-31 Thread Philippe Mathieu-Daudé
On 30/10/23 15:25, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: Hi Peter, Cc'ing Markus for QObject. On 30/10/23 12:48, Peter Maydell wrote: Convert the hw/input/stellaris_input device to qdev. The interface uses an array property for the board to specify the keycodes to use, so

Re: [PATCH v2 5/6] hw/input/stellaris_input: Convert to qdev

2023-10-30 Thread Mark Cave-Ayland
On 30/10/2023 11:48, Peter Maydell wrote: Convert the hw/input/stellaris_input device to qdev. The interface uses an array property for the board to specify the keycodes to use, so the s->keycodes memory is now allocated by the array-property machinery. Signed-off-by: Peter Maydell Reviewed-b

Re: [PATCH v2 5/6] hw/input/stellaris_input: Convert to qdev

2023-10-30 Thread Philippe Mathieu-Daudé
On 30/10/23 15:41, Peter Maydell wrote: On Mon, 30 Oct 2023 at 13:52, Philippe Mathieu-Daudé wrote: Hi Peter, Cc'ing Markus for QObject. On 30/10/23 12:48, Peter Maydell wrote: Convert the hw/input/stellaris_input device to qdev. The interface uses an array property for the board to specif

Re: [PATCH v2 5/6] hw/input/stellaris_input: Convert to qdev

2023-10-30 Thread Peter Maydell
On Mon, 30 Oct 2023 at 13:52, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > Cc'ing Markus for QObject. > > On 30/10/23 12:48, Peter Maydell wrote: > > Convert the hw/input/stellaris_input device to qdev. > > > > The interface uses an array property for the board to specify the > > keycodes to us

Re: [PATCH v2 5/6] hw/input/stellaris_input: Convert to qdev

2023-10-30 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Hi Peter, > > Cc'ing Markus for QObject. > > On 30/10/23 12:48, Peter Maydell wrote: >> Convert the hw/input/stellaris_input device to qdev. >> The interface uses an array property for the board to specify the >> keycodes to use, so the s->keycodes memory is now a

Re: [PATCH v2 5/6] hw/input/stellaris_input: Convert to qdev

2023-10-30 Thread Philippe Mathieu-Daudé
Hi Peter, Cc'ing Markus for QObject. On 30/10/23 12:48, Peter Maydell wrote: Convert the hw/input/stellaris_input device to qdev. The interface uses an array property for the board to specify the keycodes to use, so the s->keycodes memory is now allocated by the array-property machinery. Sign

[PATCH v2 5/6] hw/input/stellaris_input: Convert to qdev

2023-10-30 Thread Peter Maydell
Convert the hw/input/stellaris_input device to qdev. The interface uses an array property for the board to specify the keycodes to use, so the s->keycodes memory is now allocated by the array-property machinery. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philipp