Re: [PATCH v2 4/6] hw/char/parallel: Export ParallelState

2023-05-21 Thread Philippe Mathieu-Daudé
On 21/5/23 14:30, Bernhard Beschow wrote: Exporting ParallelState is a precondition for exporing TYPE_ISA_PARALLEL. Suggested-by: Mark Cave-Ayland Missing your S-o-b. --- include/hw/char/parallel.h | 44 ++ hw/char/parallel.c | 42 -

Re: [PATCH v2 4/6] hw/char/parallel: Export ParallelState

2023-05-21 Thread BALATON Zoltan
On Sun, 21 May 2023, Bernhard Beschow wrote: Exporting ParallelState is a precondition for exporing TYPE_ISA_PARALLEL. This may need a better commit message. It's not a precondition per coding standards I think just a preference for allowing embedding the device in other devices but otherwise

[PATCH v2 4/6] hw/char/parallel: Export ParallelState

2023-05-21 Thread Bernhard Beschow
Exporting ParallelState is a precondition for exporing TYPE_ISA_PARALLEL. Suggested-by: Mark Cave-Ayland --- include/hw/char/parallel.h | 44 ++ hw/char/parallel.c | 42 2 files changed, 44 insertions(+), 42 deletio