Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-18 Thread Akihiko Odaki
On 2024/08/18 16:03, Michael S. Tsirkin wrote: On Sun, Aug 18, 2024 at 02:04:29PM +0900, Akihiko Odaki wrote: On 2024/08/09 21:50, Fabiano Rosas wrote: Peter Xu writes: On Thu, Aug 08, 2024 at 10:47:28AM -0400, Michael S. Tsirkin wrote: On Thu, Aug 08, 2024 at 10:15:36AM -0400, Peter Xu wro

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-18 Thread Michael S. Tsirkin
On Sun, Aug 18, 2024 at 02:04:29PM +0900, Akihiko Odaki wrote: > On 2024/08/09 21:50, Fabiano Rosas wrote: > > Peter Xu writes: > > > > > On Thu, Aug 08, 2024 at 10:47:28AM -0400, Michael S. Tsirkin wrote: > > > > On Thu, Aug 08, 2024 at 10:15:36AM -0400, Peter Xu wrote: > > > > > On Thu, Aug 08,

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-17 Thread Akihiko Odaki
On 2024/08/09 0:25, Peter Xu wrote: On Thu, Aug 08, 2024 at 10:47:28AM -0400, Michael S. Tsirkin wrote: On Thu, Aug 08, 2024 at 10:15:36AM -0400, Peter Xu wrote: On Thu, Aug 08, 2024 at 07:12:14AM -0400, Michael S. Tsirkin wrote: This is too big of a hammer. People already use what you call "c

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-17 Thread Akihiko Odaki
On 2024/08/09 21:50, Fabiano Rosas wrote: Peter Xu writes: On Thu, Aug 08, 2024 at 10:47:28AM -0400, Michael S. Tsirkin wrote: On Thu, Aug 08, 2024 at 10:15:36AM -0400, Peter Xu wrote: On Thu, Aug 08, 2024 at 07:12:14AM -0400, Michael S. Tsirkin wrote: This is too big of a hammer. People al

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-11 Thread Michael S. Tsirkin
On Thu, Aug 08, 2024 at 11:25:29AM -0400, Peter Xu wrote: > On Thu, Aug 08, 2024 at 10:47:28AM -0400, Michael S. Tsirkin wrote: > > On Thu, Aug 08, 2024 at 10:15:36AM -0400, Peter Xu wrote: > > > On Thu, Aug 08, 2024 at 07:12:14AM -0400, Michael S. Tsirkin wrote: > > > > This is too big of a hammer

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-09 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Aug 08, 2024 at 10:47:28AM -0400, Michael S. Tsirkin wrote: >> On Thu, Aug 08, 2024 at 10:15:36AM -0400, Peter Xu wrote: >> > On Thu, Aug 08, 2024 at 07:12:14AM -0400, Michael S. Tsirkin wrote: >> > > This is too big of a hammer. People already use what you call "cross

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-09 Thread Akihiko Odaki
On 2024/08/08 22:55, Peter Xu wrote: On Thu, Aug 08, 2024 at 08:43:22PM +0900, Akihiko Odaki wrote: On 2024/08/07 5:41, Peter Xu wrote: On Mon, Aug 05, 2024 at 04:27:43PM +0900, Akihiko Odaki wrote: On 2024/08/04 22:08, Peter Xu wrote: On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki w

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-08 Thread Peter Xu
On Thu, Aug 08, 2024 at 10:47:28AM -0400, Michael S. Tsirkin wrote: > On Thu, Aug 08, 2024 at 10:15:36AM -0400, Peter Xu wrote: > > On Thu, Aug 08, 2024 at 07:12:14AM -0400, Michael S. Tsirkin wrote: > > > This is too big of a hammer. People already use what you call "cross > > > migrate" and have

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-08 Thread Michael S. Tsirkin
On Thu, Aug 08, 2024 at 10:15:36AM -0400, Peter Xu wrote: > On Thu, Aug 08, 2024 at 07:12:14AM -0400, Michael S. Tsirkin wrote: > > This is too big of a hammer. People already use what you call "cross > > migrate" and have for years. We are not going to stop developing > > features just because som

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-08 Thread Michael S. Tsirkin
On Thu, Aug 08, 2024 at 09:55:49AM -0400, Peter Xu wrote: > On Thu, Aug 08, 2024 at 08:43:22PM +0900, Akihiko Odaki wrote: > > On 2024/08/07 5:41, Peter Xu wrote: > > > On Mon, Aug 05, 2024 at 04:27:43PM +0900, Akihiko Odaki wrote: > > > > On 2024/08/04 22:08, Peter Xu wrote: > > > > > On Sun, Aug

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-08 Thread Peter Xu
On Thu, Aug 08, 2024 at 08:32:58PM +0900, Akihiko Odaki wrote: > On 2024/08/08 20:12, Michael S. Tsirkin wrote: > > On Thu, Aug 08, 2024 at 08:03:25PM +0900, Akihiko Odaki wrote: > > > On 2024/08/08 19:54, Michael S. Tsirkin wrote: > > > > On Thu, Aug 08, 2024 at 07:52:37PM +0900, Akihiko Odaki wro

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-08 Thread Peter Xu
On Thu, Aug 08, 2024 at 07:12:14AM -0400, Michael S. Tsirkin wrote: > This is too big of a hammer. People already use what you call "cross > migrate" and have for years. We are not going to stop developing > features just because someone suddenly became aware of some such bit. > If you care, you wi

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-08 Thread Peter Xu
On Thu, Aug 08, 2024 at 08:43:22PM +0900, Akihiko Odaki wrote: > On 2024/08/07 5:41, Peter Xu wrote: > > On Mon, Aug 05, 2024 at 04:27:43PM +0900, Akihiko Odaki wrote: > > > On 2024/08/04 22:08, Peter Xu wrote: > > > > On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote: > > > > > On 2024

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-08 Thread Akihiko Odaki
On 2024/08/07 5:41, Peter Xu wrote: On Mon, Aug 05, 2024 at 04:27:43PM +0900, Akihiko Odaki wrote: On 2024/08/04 22:08, Peter Xu wrote: On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote: On 2024/08/03 1:26, Peter Xu wrote: On Sat, Aug 03, 2024 at 12:54:51AM +0900, Akihiko Odaki wr

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-08 Thread Akihiko Odaki
On 2024/08/08 20:12, Michael S. Tsirkin wrote: On Thu, Aug 08, 2024 at 08:03:25PM +0900, Akihiko Odaki wrote: On 2024/08/08 19:54, Michael S. Tsirkin wrote: On Thu, Aug 08, 2024 at 07:52:37PM +0900, Akihiko Odaki wrote: On 2024/08/06 22:29, Michael S. Tsirkin wrote: On Tue, Aug 06, 2024 at 04

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-08 Thread Michael S. Tsirkin
On Thu, Aug 08, 2024 at 08:03:25PM +0900, Akihiko Odaki wrote: > On 2024/08/08 19:54, Michael S. Tsirkin wrote: > > On Thu, Aug 08, 2024 at 07:52:37PM +0900, Akihiko Odaki wrote: > > > On 2024/08/06 22:29, Michael S. Tsirkin wrote: > > > > On Tue, Aug 06, 2024 at 04:35:44PM +0900, Akihiko Odaki wro

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-08 Thread Akihiko Odaki
On 2024/08/08 19:54, Michael S. Tsirkin wrote: On Thu, Aug 08, 2024 at 07:52:37PM +0900, Akihiko Odaki wrote: On 2024/08/06 22:29, Michael S. Tsirkin wrote: On Tue, Aug 06, 2024 at 04:35:44PM +0900, Akihiko Odaki wrote: On 2024/08/05 19:08, Michael S. Tsirkin wrote: On Mon, Aug 05, 2024 at 06

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-08 Thread Michael S. Tsirkin
On Thu, Aug 08, 2024 at 07:52:37PM +0900, Akihiko Odaki wrote: > On 2024/08/06 22:29, Michael S. Tsirkin wrote: > > On Tue, Aug 06, 2024 at 04:35:44PM +0900, Akihiko Odaki wrote: > > > On 2024/08/05 19:08, Michael S. Tsirkin wrote: > > > > On Mon, Aug 05, 2024 at 06:37:58PM +0900, Akihiko Odaki wro

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-08 Thread Akihiko Odaki
On 2024/08/06 22:29, Michael S. Tsirkin wrote: On Tue, Aug 06, 2024 at 04:35:44PM +0900, Akihiko Odaki wrote: On 2024/08/05 19:08, Michael S. Tsirkin wrote: On Mon, Aug 05, 2024 at 06:37:58PM +0900, Akihiko Odaki wrote: If cross-migrate=off, QEMU can still migrate on the same host (checkpoint

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-06 Thread Peter Xu
On Mon, Aug 05, 2024 at 04:27:43PM +0900, Akihiko Odaki wrote: > On 2024/08/04 22:08, Peter Xu wrote: > > On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote: > > > On 2024/08/03 1:26, Peter Xu wrote: > > > > On Sat, Aug 03, 2024 at 12:54:51AM +0900, Akihiko Odaki wrote: > > > > > > > > I

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-06 Thread Michael S. Tsirkin
On Tue, Aug 06, 2024 at 04:35:44PM +0900, Akihiko Odaki wrote: > On 2024/08/05 19:08, Michael S. Tsirkin wrote: > > On Mon, Aug 05, 2024 at 06:37:58PM +0900, Akihiko Odaki wrote: > > > If cross-migrate=off, QEMU can still migrate on the same host (checkpoint > > > and restart). QEMU can also migrat

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-06 Thread Akihiko Odaki
On 2024/08/05 19:08, Michael S. Tsirkin wrote: On Mon, Aug 05, 2024 at 06:37:58PM +0900, Akihiko Odaki wrote: If cross-migrate=off, QEMU can still migrate on the same host (checkpoint and restart). QEMU can also migrate across hosts if the user ensures they are on the same platform. What is so

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-05 Thread Michael S. Tsirkin
On Mon, Aug 05, 2024 at 06:37:58PM +0900, Akihiko Odaki wrote: > If cross-migrate=off, QEMU can still migrate on the same host (checkpoint > and restart). QEMU can also migrate across hosts if the user ensures they > are on the same platform. What is so special about checkpoint/restart? I guess we

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-05 Thread Akihiko Odaki
On 2024/08/05 17:23, Michael S. Tsirkin wrote: On Mon, Aug 05, 2024 at 04:53:52PM +0900, Akihiko Odaki wrote: On 2024/08/05 16:30, Michael S. Tsirkin wrote: On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote: I suggest disabling all offload features of virtio-net with 9.2. Yea ...

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-05 Thread Michael S. Tsirkin
On Mon, Aug 05, 2024 at 04:53:52PM +0900, Akihiko Odaki wrote: > On 2024/08/05 16:30, Michael S. Tsirkin wrote: > > On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote: > > > I suggest disabling all offload features of virtio-net with 9.2. > > > > Yea ... no. > > > > > I want to keep th

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-05 Thread Akihiko Odaki
On 2024/08/05 16:30, Michael S. Tsirkin wrote: On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote: I suggest disabling all offload features of virtio-net with 9.2. Yea ... no. I want to keep things consistent so I want to disable all at once. This change will be very uncomfortable

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-05 Thread Michael S. Tsirkin
On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote: > I suggest disabling all offload features of virtio-net with 9.2. Yea ... no. > I want to keep things consistent so I want to disable all at once. This > change will be very uncomfortable for us, who are implementing offload > featur

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-05 Thread Akihiko Odaki
On 2024/08/04 22:08, Peter Xu wrote: On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote: On 2024/08/03 1:26, Peter Xu wrote: On Sat, Aug 03, 2024 at 12:54:51AM +0900, Akihiko Odaki wrote: I'm not sure if I read it right. Perhaps you meant something more generic than -platform but s

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-04 Thread Michael S. Tsirkin
On Sun, Aug 04, 2024 at 09:08:05AM -0400, Peter Xu wrote: > On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote: > > On 2024/08/03 1:26, Peter Xu wrote: > > > On Sat, Aug 03, 2024 at 12:54:51AM +0900, Akihiko Odaki wrote: > > > > > > > I'm not sure if I read it right. Perhaps you meant s

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-04 Thread Peter Xu
On Sun, Aug 04, 2024 at 03:49:45PM +0900, Akihiko Odaki wrote: > On 2024/08/03 1:26, Peter Xu wrote: > > On Sat, Aug 03, 2024 at 12:54:51AM +0900, Akihiko Odaki wrote: > > > > > > I'm not sure if I read it right. Perhaps you meant something more > > > > > > generic > > > > > > than -platform but

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-03 Thread Akihiko Odaki
On 2024/08/03 1:26, Peter Xu wrote: On Sat, Aug 03, 2024 at 12:54:51AM +0900, Akihiko Odaki wrote: I'm not sure if I read it right. Perhaps you meant something more generic than -platform but similar? For example, "-profile [PROFILE]" qemu cmdline, where PROFILE can be either "perf" or "compat

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-02 Thread Peter Xu
On Fri, Aug 02, 2024 at 12:40:33PM -0400, Michael S. Tsirkin wrote: > On Fri, Aug 02, 2024 at 12:26:22PM -0400, Peter Xu wrote: > > And that's why I was thinking (where I totally agree with you on this) that > > whether we should settle a short term plan first to be on the safe side > > that we sta

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-02 Thread Michael S. Tsirkin
On Fri, Aug 02, 2024 at 12:26:22PM -0400, Peter Xu wrote: > And that's why I was thinking (where I totally agree with you on this) that > whether we should settle a short term plan first to be on the safe side > that we start with migration always being compatible, then we figure the > other approa

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-02 Thread Peter Xu
On Sat, Aug 03, 2024 at 12:54:51AM +0900, Akihiko Odaki wrote: > > > > I'm not sure if I read it right. Perhaps you meant something more > > > > generic > > > > than -platform but similar? > > > > > > > > For example, "-profile [PROFILE]" qemu cmdline, where PROFILE can be > > > > either > > >

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-02 Thread Akihiko Odaki
On 2024/08/03 0:05, Peter Xu wrote: On Fri, Aug 02, 2024 at 01:30:51PM +0900, Akihiko Odaki wrote: On 2024/08/02 0:13, Peter Xu wrote: On Thu, Aug 01, 2024 at 02:05:54PM +0900, Akihiko Odaki wrote: On 2024/07/31 4:11, Peter Xu wrote: On Tue, Jul 30, 2024 at 07:46:12PM +0100, Daniel P. Berrang

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-02 Thread Peter Xu
On Fri, Aug 02, 2024 at 01:30:51PM +0900, Akihiko Odaki wrote: > On 2024/08/02 0:13, Peter Xu wrote: > > On Thu, Aug 01, 2024 at 02:05:54PM +0900, Akihiko Odaki wrote: > > > On 2024/07/31 4:11, Peter Xu wrote: > > > > On Tue, Jul 30, 2024 at 07:46:12PM +0100, Daniel P. Berrangé wrote: > > > > > On

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-02 Thread Michael S. Tsirkin
On Fri, Aug 02, 2024 at 01:30:51PM +0900, Akihiko Odaki wrote: > 4) is the second easiest to implement, but the design of 4) will depend on > whether we will satisfy 2) or 3). In the email I cited earlier, I suggested > an option -use-platform to specify the expectation on the platform. If it is >

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-01 Thread Akihiko Odaki
On 2024/08/02 0:13, Peter Xu wrote: On Thu, Aug 01, 2024 at 02:05:54PM +0900, Akihiko Odaki wrote: On 2024/07/31 4:11, Peter Xu wrote: On Tue, Jul 30, 2024 at 07:46:12PM +0100, Daniel P. Berrangé wrote: On Tue, Jul 30, 2024 at 02:13:51PM -0400, Peter Xu wrote: On Mon, Jul 29, 2024 at 06:26:41

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-01 Thread Daniel P . Berrangé
On Thu, Aug 01, 2024 at 11:50:40AM -0400, Michael S. Tsirkin wrote: > On Thu, Aug 01, 2024 at 04:45:17PM +0100, Daniel P. Berrangé wrote: > > So to ensure a QEMU is started with migration compatible features > > will still require teaching libvirt about every single feature > > that has a host kern

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 04:45:17PM +0100, Daniel P. Berrangé wrote: > So to ensure a QEMU is started with migration compatible features > will still require teaching libvirt about every single feature > that has a host kernel dependancy, so libvirt (or the app using > libvirt) knows to turn this of

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-01 Thread Daniel P . Berrangé
On Thu, Aug 01, 2024 at 01:51:00AM -0400, Michael S. Tsirkin wrote: > On Wed, Jul 31, 2024 at 08:57:52AM -0400, Peter Xu wrote: > > Could you elaborate why it would fail if with what I proposed? > > First I think I was wrong I misunderstood what you said. > To summarise, you said: > > - any new f

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 11:36:19AM -0400, Peter Xu wrote: > On Thu, Aug 01, 2024 at 01:51:00AM -0400, Michael S. Tsirkin wrote: > > So I suggest a single command that dumps some description of host > > features, to be passed to qemu on destination. qemu then fails to > > start on destination if som

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-01 Thread Peter Xu
On Thu, Aug 01, 2024 at 01:51:00AM -0400, Michael S. Tsirkin wrote: > So I suggest a single command that dumps some description of host > features, to be passed to qemu on destination. qemu then fails to > start on destination if some of these do not work. > The advantage is that this also helps th

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-01 Thread Daniel P . Berrangé
On Thu, Aug 01, 2024 at 11:15:47AM -0400, Michael S. Tsirkin wrote: > On Thu, Aug 01, 2024 at 11:13:37AM -0400, Peter Xu wrote: > > Do we really concern about users not enabling features that much? I > > thought users always can manually change the XML and add whatever they > > need, and device pr

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 11:13:37AM -0400, Peter Xu wrote: > Do we really concern about users not enabling features that much? I > thought users always can manually change the XML and add whatever they > need, and device properties do not like too special here to me. I mean, we > have bunch of "fe

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-01 Thread Peter Xu
On Thu, Aug 01, 2024 at 02:05:54PM +0900, Akihiko Odaki wrote: > On 2024/07/31 4:11, Peter Xu wrote: > > On Tue, Jul 30, 2024 at 07:46:12PM +0100, Daniel P. Berrangé wrote: > > > On Tue, Jul 30, 2024 at 02:13:51PM -0400, Peter Xu wrote: > > > > On Mon, Jul 29, 2024 at 06:26:41PM +0100, Daniel P. Be

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-31 Thread Michael S. Tsirkin
On Wed, Jul 31, 2024 at 08:57:52AM -0400, Peter Xu wrote: > Could you elaborate why it would fail if with what I proposed? First I think I was wrong I misunderstood what you said. To summarise, you said: - any new feature depending on another package is off by default - starting qemu on destinati

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-31 Thread Michael S. Tsirkin
On Fri, Jul 26, 2024 at 07:39:46PM +0200, Thomas Huth wrote: > Anyway, while we're discussing solutions: We are in softfreeze already. > Should we disable the UFO bits in the new 9.1 machine type for the time > being to avoid that more people are running into this problem? At the moment I'm lookin

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-31 Thread Michael S. Tsirkin
On Tue, Jul 30, 2024 at 02:02:27AM +0900, Akihiko Odaki wrote: > I think it is simpler to analyze the platform dependency and dump it for the > management layer. For example, libvirt can request QEMU to analyze the > platform dependency when it creates a new domain. QEMU will then figure out > that

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-31 Thread Michael S. Tsirkin
On Wed, Jul 31, 2024 at 08:57:52AM -0400, Peter Xu wrote: > > > > The right solution is to have a tool that can query > > backends, and that given the results from all of the cluster, > > generate a set of parameters that will ensure migration works. > > Kind of like qemu-img, but for migration. >

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-31 Thread Akihiko Odaki
On 2024/08/01 11:28, Jason Wang wrote: On Wed, Jul 31, 2024 at 8:58 PM Peter Xu wrote: On Wed, Jul 31, 2024 at 03:41:00AM -0400, Michael S. Tsirkin wrote: On Wed, Jul 31, 2024 at 08:04:24AM +0100, Daniel P. Berrangé wrote: On Tue, Jul 30, 2024 at 05:32:48PM -0400, Michael S. Tsirkin wrote:

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-31 Thread Akihiko Odaki
On 2024/07/31 4:11, Peter Xu wrote: On Tue, Jul 30, 2024 at 07:46:12PM +0100, Daniel P. Berrangé wrote: On Tue, Jul 30, 2024 at 02:13:51PM -0400, Peter Xu wrote: On Mon, Jul 29, 2024 at 06:26:41PM +0100, Daniel P. Berrangé wrote: On Mon, Jul 29, 2024 at 01:00:30PM -0400, Peter Xu wrote: On Mo

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-31 Thread Jason Wang
On Wed, Jul 31, 2024 at 8:58 PM Peter Xu wrote: > > On Wed, Jul 31, 2024 at 03:41:00AM -0400, Michael S. Tsirkin wrote: > > On Wed, Jul 31, 2024 at 08:04:24AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Jul 30, 2024 at 05:32:48PM -0400, Michael S. Tsirkin wrote: > > > > On Tue, Jul 30, 2024 at

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-31 Thread Peter Xu
On Wed, Jul 31, 2024 at 03:41:00AM -0400, Michael S. Tsirkin wrote: > On Wed, Jul 31, 2024 at 08:04:24AM +0100, Daniel P. Berrangé wrote: > > On Tue, Jul 30, 2024 at 05:32:48PM -0400, Michael S. Tsirkin wrote: > > > On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > > > > On Tue, Jul 30, 2

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-31 Thread Michael S. Tsirkin
On Wed, Jul 31, 2024 at 08:04:24AM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 30, 2024 at 05:32:48PM -0400, Michael S. Tsirkin wrote: > > On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > > > On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > > > > This is not what

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-31 Thread Daniel P . Berrangé
On Tue, Jul 30, 2024 at 05:32:48PM -0400, Michael S. Tsirkin wrote: > On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > > On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > > > This is not what we did historically. Why should we start now? > > > > It's a matter of whet

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Jason Wang
On Tue, Jul 30, 2024 at 6:23 PM Akihiko Odaki wrote: > > On 2024/07/30 12:45, Jason Wang wrote: > > On Tue, Jul 30, 2024 at 11:29 AM Akihiko Odaki > > wrote: > >> > >> On 2024/07/30 12:17, Jason Wang wrote: > >>> On Tue, Jul 30, 2024 at 11:12 AM Akihiko Odaki > >>> wrote: > > On 2024

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Jason Wang
On Wed, Jul 31, 2024 at 5:33 AM Michael S. Tsirkin wrote: > > On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > > On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > > > This is not what we did historically. Why should we start now? > > > > It's a matter of whether we s

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Peter Xu
On Tue, Jul 30, 2024 at 05:32:48PM -0400, Michael S. Tsirkin wrote: > On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > > On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > > > This is not what we did historically. Why should we start now? > > > > It's a matter of whet

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Michael S. Tsirkin
On Tue, Jul 30, 2024 at 04:03:53PM -0400, Peter Xu wrote: > On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > > This is not what we did historically. Why should we start now? > > It's a matter of whether we still want migration to randomly fail, like > what this patch does. >

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Peter Xu
On Tue, Jul 30, 2024 at 03:22:50PM -0400, Michael S. Tsirkin wrote: > This is not what we did historically. Why should we start now? It's a matter of whether we still want migration to randomly fail, like what this patch does. Or any better suggestions? I'm definitely open to that. Thanks, --

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Michael S. Tsirkin
On Tue, Jul 30, 2024 at 03:11:03PM -0400, Peter Xu wrote: > On Tue, Jul 30, 2024 at 07:46:12PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jul 30, 2024 at 02:13:51PM -0400, Peter Xu wrote: > > > On Mon, Jul 29, 2024 at 06:26:41PM +0100, Daniel P. Berrangé wrote: > > > > On Mon, Jul 29, 2024 at 01:

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Peter Xu
On Tue, Jul 30, 2024 at 07:46:12PM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 30, 2024 at 02:13:51PM -0400, Peter Xu wrote: > > On Mon, Jul 29, 2024 at 06:26:41PM +0100, Daniel P. Berrangé wrote: > > > On Mon, Jul 29, 2024 at 01:00:30PM -0400, Peter Xu wrote: > > > > On Mon, Jul 29, 2024 at 04:

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Daniel P . Berrangé
On Tue, Jul 30, 2024 at 02:13:51PM -0400, Peter Xu wrote: > On Mon, Jul 29, 2024 at 06:26:41PM +0100, Daniel P. Berrangé wrote: > > On Mon, Jul 29, 2024 at 01:00:30PM -0400, Peter Xu wrote: > > > On Mon, Jul 29, 2024 at 04:58:03PM +0100, Daniel P. Berrangé wrote: > > > > > > > > We've got two mutu

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Peter Xu
On Mon, Jul 29, 2024 at 06:26:41PM +0100, Daniel P. Berrangé wrote: > On Mon, Jul 29, 2024 at 01:00:30PM -0400, Peter Xu wrote: > > On Mon, Jul 29, 2024 at 04:58:03PM +0100, Daniel P. Berrangé wrote: > > > > > > We've got two mutually conflicting goals with the machine type > > > definitions. > >

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Peter Xu
On Tue, Jul 30, 2024 at 02:23:46AM +0900, Akihiko Odaki wrote: > On 2024/07/30 2:00, Peter Xu wrote: > > On Mon, Jul 29, 2024 at 04:58:03PM +0100, Daniel P. Berrangé wrote: > > > On Fri, Jul 26, 2024 at 04:47:40PM -0400, Peter Xu wrote: > > > > On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Be

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Yuri Benditovich
@Akihiko Odaki The RSC is supported with vhost and without vhost The 'in-qemu RSC' is related to VIRTIO_NET_F_RSC_EXT feature, it is intended for one specific WHCK test only and should not be used in any functional setup. When it is used the vhost should be off On Tue, Jul 30, 2024 at 1:23 PM Akih

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-30 Thread Akihiko Odaki
On 2024/07/30 12:45, Jason Wang wrote: On Tue, Jul 30, 2024 at 11:29 AM Akihiko Odaki wrote: On 2024/07/30 12:17, Jason Wang wrote: On Tue, Jul 30, 2024 at 11:12 AM Akihiko Odaki wrote: On 2024/07/30 12:03, Jason Wang wrote: On Tue, Jul 30, 2024 at 10:57 AM Akihiko Odaki wrote: On 2024

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Jason Wang
On Tue, Jul 30, 2024 at 11:29 AM Akihiko Odaki wrote: > > On 2024/07/30 12:17, Jason Wang wrote: > > On Tue, Jul 30, 2024 at 11:12 AM Akihiko Odaki > > wrote: > >> > >> On 2024/07/30 12:03, Jason Wang wrote: > >>> On Tue, Jul 30, 2024 at 10:57 AM Akihiko Odaki > >>> wrote: > > On 202

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Akihiko Odaki
On 2024/07/30 11:04, Jason Wang wrote: On Tue, Jul 30, 2024 at 12:43 AM Akihiko Odaki wrote: On 2024/07/29 23:29, Peter Xu wrote: On Mon, Jul 29, 2024 at 01:45:12PM +0900, Akihiko Odaki wrote: On 2024/07/29 12:50, Jason Wang wrote: On Sun, Jul 28, 2024 at 11:19 PM Akihiko Odaki wrote: On

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Akihiko Odaki
On 2024/07/30 12:17, Jason Wang wrote: On Tue, Jul 30, 2024 at 11:12 AM Akihiko Odaki wrote: On 2024/07/30 12:03, Jason Wang wrote: On Tue, Jul 30, 2024 at 10:57 AM Akihiko Odaki wrote: On 2024/07/30 11:04, Jason Wang wrote: On Tue, Jul 30, 2024 at 12:43 AM Akihiko Odaki wrote: On 2024

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Akihiko Odaki
On 2024/07/30 12:03, Jason Wang wrote: On Tue, Jul 30, 2024 at 10:57 AM Akihiko Odaki wrote: On 2024/07/30 11:04, Jason Wang wrote: On Tue, Jul 30, 2024 at 12:43 AM Akihiko Odaki wrote: On 2024/07/29 23:29, Peter Xu wrote: On Mon, Jul 29, 2024 at 01:45:12PM +0900, Akihiko Odaki wrote: On

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Jason Wang
On Tue, Jul 30, 2024 at 11:12 AM Akihiko Odaki wrote: > > On 2024/07/30 12:03, Jason Wang wrote: > > On Tue, Jul 30, 2024 at 10:57 AM Akihiko Odaki > > wrote: > >> > >> On 2024/07/30 11:04, Jason Wang wrote: > >>> On Tue, Jul 30, 2024 at 12:43 AM Akihiko Odaki > >>> wrote: > > On 202

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Jason Wang
On Tue, Jul 30, 2024 at 10:57 AM Akihiko Odaki wrote: > > On 2024/07/30 11:04, Jason Wang wrote: > > On Tue, Jul 30, 2024 at 12:43 AM Akihiko Odaki > > wrote: > >> > >> On 2024/07/29 23:29, Peter Xu wrote: > >>> On Mon, Jul 29, 2024 at 01:45:12PM +0900, Akihiko Odaki wrote: > On 2024/07/29

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Jason Wang
On Tue, Jul 30, 2024 at 12:43 AM Akihiko Odaki wrote: > > On 2024/07/29 23:29, Peter Xu wrote: > > On Mon, Jul 29, 2024 at 01:45:12PM +0900, Akihiko Odaki wrote: > >> On 2024/07/29 12:50, Jason Wang wrote: > >>> On Sun, Jul 28, 2024 at 11:19 PM Akihiko Odaki > >>> wrote: > > On 2024/07

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Daniel P . Berrangé
On Mon, Jul 29, 2024 at 01:00:30PM -0400, Peter Xu wrote: > On Mon, Jul 29, 2024 at 04:58:03PM +0100, Daniel P. Berrangé wrote: > > > > We've got two mutually conflicting goals with the machine type > > definitions. > > > > Primarily we use them to ensure stable ABI, but an important > > secondar

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Akihiko Odaki
On 2024/07/30 2:00, Peter Xu wrote: On Mon, Jul 29, 2024 at 04:58:03PM +0100, Daniel P. Berrangé wrote: On Fri, Jul 26, 2024 at 04:47:40PM -0400, Peter Xu wrote: On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: In terms of launching QEMU I'd imagine: $QEMU -machine pc-q

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Akihiko Odaki
On 2024/07/30 0:58, Daniel P. Berrangé wrote: On Fri, Jul 26, 2024 at 04:47:40PM -0400, Peter Xu wrote: On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: In terms of launching QEMU I'd imagine: $QEMU -machine pc-q35-9.1 -platform linux-6.9 ...args... Any virtual machine

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Peter Xu
On Mon, Jul 29, 2024 at 04:58:03PM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 26, 2024 at 04:47:40PM -0400, Peter Xu wrote: > > On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: > > > > > > In terms of launching QEMU I'd imagine: > > > > > > $QEMU -machine pc-q35-9.1 -plat

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Akihiko Odaki
On 2024/07/29 23:29, Peter Xu wrote: On Mon, Jul 29, 2024 at 01:45:12PM +0900, Akihiko Odaki wrote: On 2024/07/29 12:50, Jason Wang wrote: On Sun, Jul 28, 2024 at 11:19 PM Akihiko Odaki wrote: On 2024/07/27 5:47, Peter Xu wrote: On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé w

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Daniel P . Berrangé
On Fri, Jul 26, 2024 at 04:47:40PM -0400, Peter Xu wrote: > On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: > > > > In terms of launching QEMU I'd imagine: > > > > $QEMU -machine pc-q35-9.1 -platform linux-6.9 ...args... > > > > Any virtual machine HW features which are tie

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-29 Thread Peter Xu
On Mon, Jul 29, 2024 at 01:45:12PM +0900, Akihiko Odaki wrote: > On 2024/07/29 12:50, Jason Wang wrote: > > On Sun, Jul 28, 2024 at 11:19 PM Akihiko Odaki > > wrote: > > > > > > On 2024/07/27 5:47, Peter Xu wrote: > > > > On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: > > >

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-28 Thread Akihiko Odaki
On 2024/07/29 12:50, Jason Wang wrote: On Sun, Jul 28, 2024 at 11:19 PM Akihiko Odaki wrote: On 2024/07/27 5:47, Peter Xu wrote: On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: On Fri, Jul 26, 2024 at 10:43:42AM -0400, Peter Xu wrote: On Fri, Jul 26, 2024 at 09:48:02AM +

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-28 Thread Jason Wang
On Fri, Jul 26, 2024 at 2:08 PM Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2024 at 06:18:20PM -0400, Peter Xu wrote: > > On Tue, Aug 01, 2023 at 01:31:48AM +0300, Yuri Benditovich wrote: > > > USO features of virtio-net device depend on kernel ability > > > to support them, for backward compati

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-28 Thread Jason Wang
On Sun, Jul 28, 2024 at 11:19 PM Akihiko Odaki wrote: > > On 2024/07/27 5:47, Peter Xu wrote: > > On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: > >> On Fri, Jul 26, 2024 at 10:43:42AM -0400, Peter Xu wrote: > >>> On Fri, Jul 26, 2024 at 09:48:02AM +0100, Daniel P. Berrangé wr

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-28 Thread Akihiko Odaki
On 2024/07/27 5:47, Peter Xu wrote: On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: On Fri, Jul 26, 2024 at 10:43:42AM -0400, Peter Xu wrote: On Fri, Jul 26, 2024 at 09:48:02AM +0100, Daniel P. Berrangé wrote: On Fri, Jul 26, 2024 at 09:03:24AM +0200, Thomas Huth wrote: On

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-26 Thread Peter Xu
On Fri, Jul 26, 2024 at 07:39:46PM +0200, Thomas Huth wrote: > On 26/07/2024 09.25, Michael S. Tsirkin wrote: > > On Fri, Jul 26, 2024 at 09:03:24AM +0200, Thomas Huth wrote: > > > On 26/07/2024 08.08, Michael S. Tsirkin wrote: > > > > On Thu, Jul 25, 2024 at 06:18:20PM -0400, Peter Xu wrote: > > >

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-26 Thread Peter Xu
On Fri, Jul 26, 2024 at 04:17:12PM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 26, 2024 at 10:43:42AM -0400, Peter Xu wrote: > > On Fri, Jul 26, 2024 at 09:48:02AM +0100, Daniel P. Berrangé wrote: > > > On Fri, Jul 26, 2024 at 09:03:24AM +0200, Thomas Huth wrote: > > > > On 26/07/2024 08.08, Mic

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-26 Thread Thomas Huth
On 26/07/2024 09.25, Michael S. Tsirkin wrote: On Fri, Jul 26, 2024 at 09:03:24AM +0200, Thomas Huth wrote: On 26/07/2024 08.08, Michael S. Tsirkin wrote: On Thu, Jul 25, 2024 at 06:18:20PM -0400, Peter Xu wrote: On Tue, Aug 01, 2023 at 01:31:48AM +0300, Yuri Benditovich wrote: USO features o

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-26 Thread Daniel P . Berrangé
On Fri, Jul 26, 2024 at 10:43:42AM -0400, Peter Xu wrote: > On Fri, Jul 26, 2024 at 09:48:02AM +0100, Daniel P. Berrangé wrote: > > On Fri, Jul 26, 2024 at 09:03:24AM +0200, Thomas Huth wrote: > > > On 26/07/2024 08.08, Michael S. Tsirkin wrote: > > > > On Thu, Jul 25, 2024 at 06:18:20PM -0400, Pet

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-26 Thread Peter Xu
On Fri, Jul 26, 2024 at 10:12:31AM +0800, Jason Wang wrote: > On Fri, Jul 26, 2024 at 6:19 AM Peter Xu wrote: > > > > On Tue, Aug 01, 2023 at 01:31:48AM +0300, Yuri Benditovich wrote: > > > USO features of virtio-net device depend on kernel ability > > > to support them, for backward compatibility

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-26 Thread Peter Xu
On Fri, Jul 26, 2024 at 09:48:02AM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 26, 2024 at 09:03:24AM +0200, Thomas Huth wrote: > > On 26/07/2024 08.08, Michael S. Tsirkin wrote: > > > On Thu, Jul 25, 2024 at 06:18:20PM -0400, Peter Xu wrote: > > > > On Tue, Aug 01, 2023 at 01:31:48AM +0300, Yur

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-26 Thread Peter Xu
On Fri, Jul 26, 2024 at 03:25:31AM -0400, Michael S. Tsirkin wrote: > On Fri, Jul 26, 2024 at 09:03:24AM +0200, Thomas Huth wrote: > > On 26/07/2024 08.08, Michael S. Tsirkin wrote: > > > On Thu, Jul 25, 2024 at 06:18:20PM -0400, Peter Xu wrote: > > > > On Tue, Aug 01, 2023 at 01:31:48AM +0300, Yur

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-26 Thread Daniel P . Berrangé
On Fri, Jul 26, 2024 at 09:03:24AM +0200, Thomas Huth wrote: > On 26/07/2024 08.08, Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2024 at 06:18:20PM -0400, Peter Xu wrote: > > > On Tue, Aug 01, 2023 at 01:31:48AM +0300, Yuri Benditovich wrote: > > > > USO features of virtio-net device depend on ker

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-26 Thread Michael S. Tsirkin
On Fri, Jul 26, 2024 at 09:03:24AM +0200, Thomas Huth wrote: > On 26/07/2024 08.08, Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2024 at 06:18:20PM -0400, Peter Xu wrote: > > > On Tue, Aug 01, 2023 at 01:31:48AM +0300, Yuri Benditovich wrote: > > > > USO features of virtio-net device depend on ker

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-26 Thread Thomas Huth
On 26/07/2024 08.08, Michael S. Tsirkin wrote: On Thu, Jul 25, 2024 at 06:18:20PM -0400, Peter Xu wrote: On Tue, Aug 01, 2023 at 01:31:48AM +0300, Yuri Benditovich wrote: USO features of virtio-net device depend on kernel ability to support them, for backward compatibility by default the featur

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2024 at 06:18:20PM -0400, Peter Xu wrote: > On Tue, Aug 01, 2023 at 01:31:48AM +0300, Yuri Benditovich wrote: > > USO features of virtio-net device depend on kernel ability > > to support them, for backward compatibility by default the > > features are disabled on 8.0 and earlier. >

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-25 Thread Jason Wang
On Fri, Jul 26, 2024 at 6:19 AM Peter Xu wrote: > > On Tue, Aug 01, 2023 at 01:31:48AM +0300, Yuri Benditovich wrote: > > USO features of virtio-net device depend on kernel ability > > to support them, for backward compatibility by default the > > features are disabled on 8.0 and earlier. > > > >

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-07-25 Thread Peter Xu
On Tue, Aug 01, 2023 at 01:31:48AM +0300, Yuri Benditovich wrote: > USO features of virtio-net device depend on kernel ability > to support them, for backward compatibility by default the > features are disabled on 8.0 and earlier. > > Signed-off-by: Yuri Benditovich > Signed-off-by: Andrew Melny

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2023-08-01 Thread Akihiko Odaki
On 2023/08/01 7:31, Yuri Benditovich wrote: USO features of virtio-net device depend on kernel ability to support them, for backward compatibility by default the features are disabled on 8.0 and earlier. Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychecnko --- hw/core/machine.c

  1   2   >