Re: [PATCH v2 3/8] migration: Add spaces around operator

2020-10-19 Thread Bihong Yu
OK, I will change it to "VMStateDescription *[]". Thank you for your review. On 2020/10/19 19:59, Markus Armbruster wrote: > Bihong Yu writes: > >> Yes, I used to think "const VMStateDescription *[]" was right, but when I >> search >> similar expressions, most of all are "xxx * []". Such as: >>

Re: [PATCH v2 3/8] migration: Add spaces around operator

2020-10-19 Thread Markus Armbruster
Bihong Yu writes: > Yes, I used to think "const VMStateDescription *[]" was right, but when I > search > similar expressions, most of all are "xxx * []". Such as: > fsdev/qemu-fsdev.c:54:.opts = (const char * []) > hw/intc/s390_flic_kvm.c:567:.subsections = (const VMStateDescription

Re: [PATCH v2 3/8] migration: Add spaces around operator

2020-10-19 Thread Bihong Yu
Yes, I used to think "const VMStateDescription *[]" was right, but when I search similar expressions, most of all are "xxx * []". Such as: fsdev/qemu-fsdev.c:54:.opts = (const char * []) hw/intc/s390_flic_kvm.c:567:.subsections = (const VMStateDescription * []) ... So, I keep the same

Re: [PATCH v2 3/8] migration: Add spaces around operator

2020-10-19 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Bihong Yu (yubih...@huawei.com) wrote: >> Signed-off-by: Bihong Yu >> Reviewed-by: Chuan Zheng > > Yes that's OK, I'm a bit sturprised we need the space afte rthe * in the > VMStateDescription case, I wouldn't necessarily go and change them all. We don't: i

Re: [PATCH v2 3/8] migration: Add spaces around operator

2020-10-13 Thread Dr. David Alan Gilbert
* Bihong Yu (yubih...@huawei.com) wrote: > Signed-off-by: Bihong Yu > Reviewed-by: Chuan Zheng Yes that's OK, I'm a bit sturprised we need the space afte rthe * in the VMStateDescription case, I wouldn't necessarily go and change them all. Reviewed-by: Dr. David Alan Gilbert > --- > migrat

[PATCH v2 3/8] migration: Add spaces around operator

2020-10-12 Thread Bihong Yu
Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng --- migration/migration.c| 4 ++-- migration/postcopy-ram.c | 2 +- migration/ram.c | 2 +- migration/savevm.c | 2 +- migration/vmstate.c | 10 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git