Re: [PATCH v2 3/6] qtest: implement named interception of out-GPIO

2023-07-28 Thread Peter Maydell
On Thu, 27 Jul 2023 at 22:32, Chris Laplante wrote: > > > > (g_strcmp0() can handle the NULL case without having > > to special case it -- this is how qdev_get_named_gpio_list() > > finds entries in the ngl list.) > > > > Apologies for not noticing that on the first round of review. > > No worries

Re: [PATCH v2 3/6] qtest: implement named interception of out-GPIO

2023-07-27 Thread Chris Laplante
> (g_strcmp0() can handle the NULL case without having > to special case it -- this is how qdev_get_named_gpio_list() > finds entries in the ngl list.) > > Apologies for not noticing that on the first round of review. No worries - it makes the code much simpler anyway. Should we bother factorin

Re: [PATCH v2 3/6] qtest: implement named interception of out-GPIO

2023-07-27 Thread Peter Maydell
On Wed, 26 Jul 2023 at 04:32, Chris Laplante wrote: > > Adds qtest_irq_intercept_out_named method, which utilizes a new optional > name parameter to the irq_intercept_out qtest command. > > Signed-off-by: Chris Laplante > --- > softmmu/qtest.c| 24 > tests/qtest/

[PATCH v2 3/6] qtest: implement named interception of out-GPIO

2023-07-25 Thread Chris Laplante
Adds qtest_irq_intercept_out_named method, which utilizes a new optional name parameter to the irq_intercept_out qtest command. Signed-off-by: Chris Laplante --- softmmu/qtest.c| 24 tests/qtest/libqtest.c | 6 ++ tests/qtest/libqtest.h | 11 +++ 3 f