Re: [PATCH v2 3/6] qemu-img: Add bitmap sub-command

2020-05-04 Thread Eric Blake
On 5/4/20 5:01 AM, Max Reitz wrote: +.. option:: bitmap {--add [-g GRANULARITY] [--disabled] | --remove | --clear | --enable | --disable | --merge SOURCE_BITMAP [-b SOURCE_FILE [-F SOURCE_FMT]]} [--object OBJECTDEF] [--image-opts] [-f FMT] FILENAME BITMAP So I can do multiple operations in one

Re: [PATCH v2 3/6] qemu-img: Add bitmap sub-command

2020-05-04 Thread Max Reitz
On 30.04.20 17:21, Eric Blake wrote: > On 4/30/20 9:55 AM, Max Reitz wrote: >> On 21.04.20 23:20, Eric Blake wrote: >>> Include actions for --add, --remove, --clear, --enable, --disable, and >>> --merge (note that --clear is a bit of fluff, because the same can be >>> accomplished by removing a bit

Re: [PATCH v2 3/6] qemu-img: Add bitmap sub-command

2020-04-30 Thread Eric Blake
On 4/30/20 9:55 AM, Max Reitz wrote: On 21.04.20 23:20, Eric Blake wrote: Include actions for --add, --remove, --clear, --enable, --disable, and --merge (note that --clear is a bit of fluff, because the same can be accomplished by removing a bitmap and then adding a new one in its place, Well,

Re: [PATCH v2 3/6] qemu-img: Add bitmap sub-command

2020-04-30 Thread Max Reitz
On 21.04.20 23:20, Eric Blake wrote: > Include actions for --add, --remove, --clear, --enable, --disable, and > --merge (note that --clear is a bit of fluff, because the same can be > accomplished by removing a bitmap and then adding a new one in its > place, Well, ideally, all of qemu-img is just

[PATCH v2 3/6] qemu-img: Add bitmap sub-command

2020-04-21 Thread Eric Blake
Include actions for --add, --remove, --clear, --enable, --disable, and --merge (note that --clear is a bit of fluff, because the same can be accomplished by removing a bitmap and then adding a new one in its place, but it matches what QMP commands exist). Listing is omitted, because it does not re