Re: [PATCH v2 3/6] qapi: Remove wrapper struct for simple unions

2020-10-26 Thread Kevin Wolf
Am 25.10.2020 um 10:16 hat Markus Armbruster geschrieben: > I apologize for writing so much. It's the only way I know to figure out > how things work. > > This may feel like I'm trying to shoot down your patch. I'm not! I'm > merely trying to understand and maybe improve it. I'd love to get ri

Re: [PATCH v2 3/6] qapi: Remove wrapper struct for simple unions

2020-10-25 Thread Markus Armbruster
I apologize for writing so much. It's the only way I know to figure out how things work. This may feel like I'm trying to shoot down your patch. I'm not! I'm merely trying to understand and maybe improve it. I'd love to get rid of implicit wrapper objects, actually. They complicate things in

[PATCH v2 3/6] qapi: Remove wrapper struct for simple unions

2020-10-23 Thread Kevin Wolf
Variants of simple unions are always contained in a wrapper object called 'data' that serves no real use. When mapping a QAPI object to the command line, this becomes very visible to users because they have to add one or more useless 'data.' to many option names. As a first step towards avoiding t