Re: [PATCH v2 3/5] msmouse: Use fifo8 instead of array

2022-09-11 Thread Arwed Meyer
Am 11.09.22 um 08:12 schrieb Volker Rümelin: Am 08.09.22 um 19:31 schrieb Arwed Meyer: @@ -54,21 +60,15 @@ DECLARE_INSTANCE_CHECKER(MouseChardev, MOUSE_CHARDEV,   static void msmouse_chr_accept_input(Chardev *chr)   {   MouseChardev *mouse = MOUSE_CHARDEV(chr); -    int len; +    uint32_t l

Re: [PATCH v2 3/5] msmouse: Use fifo8 instead of array

2022-09-11 Thread Arwed Meyer
Hi, Am 09.09.22 um 15:18 schrieb Marc-André Lureau: Hi On Thu, Sep 8, 2022 at 9:38 PM Arwed Meyer mailto:arwed.me...@gmx.de>> wrote: Make use of fifo8 functions instead of implementing own fifo code. This makes the code more readable and reduces risk of bugs. Signed-off-by: Arwed

Re: [PATCH v2 3/5] msmouse: Use fifo8 instead of array

2022-09-10 Thread Volker Rümelin
Am 08.09.22 um 19:31 schrieb Arwed Meyer: @@ -54,21 +60,15 @@ DECLARE_INSTANCE_CHECKER(MouseChardev, MOUSE_CHARDEV, static void msmouse_chr_accept_input(Chardev *chr) { MouseChardev *mouse = MOUSE_CHARDEV(chr); -int len; +uint32_t len_out, len; -len = qemu_chr_be_can_write

Re: [PATCH v2 3/5] msmouse: Use fifo8 instead of array

2022-09-09 Thread Marc-André Lureau
Hi On Thu, Sep 8, 2022 at 9:38 PM Arwed Meyer wrote: > Make use of fifo8 functions instead of implementing own fifo code. > This makes the code more readable and reduces risk of bugs. > > Signed-off-by: Arwed Meyer > Reviewed-by: Marc-André Lureau > --- > chardev/msmouse.c | 43 +++

[PATCH v2 3/5] msmouse: Use fifo8 instead of array

2022-09-08 Thread Arwed Meyer
Make use of fifo8 functions instead of implementing own fifo code. This makes the code more readable and reduces risk of bugs. Signed-off-by: Arwed Meyer --- chardev/msmouse.c | 43 +-- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/charde