Re: [PATCH v2 3/4] hw/vfio-user: wait for proxy close correctly

2025-07-15 Thread Cédric Le Goater
On 7/15/25 11:33, John Levon wrote: On Tue, Jul 15, 2025 at 10:01:59AM +0100, Mark Cave-Ayland wrote: On 15/07/2025 06:52, John Levon wrote: Coverity reported: CID 1611806: Concurrent data access violations (BAD_CHECK_OF_WAIT_COND) A wait is performed without a loop. If there is a spurious

Re: [PATCH v2 3/4] hw/vfio-user: wait for proxy close correctly

2025-07-15 Thread John Levon
On Tue, Jul 15, 2025 at 10:01:59AM +0100, Mark Cave-Ayland wrote: > On 15/07/2025 06:52, John Levon wrote: > > > Coverity reported: > > > > CID 1611806: Concurrent data access violations (BAD_CHECK_OF_WAIT_COND) > > > > A wait is performed without a loop. If there is a spurious wakeup, the > >

Re: [PATCH v2 3/4] hw/vfio-user: wait for proxy close correctly

2025-07-15 Thread Mark Cave-Ayland
On 15/07/2025 06:52, John Levon wrote: Coverity reported: CID 1611806: Concurrent data access violations (BAD_CHECK_OF_WAIT_COND) A wait is performed without a loop. If there is a spurious wakeup, the condition may not be satisfied. Fix this by checking ->state for VFIO_PROXY_CLOSED in a loop

[PATCH v2 3/4] hw/vfio-user: wait for proxy close correctly

2025-07-14 Thread John Levon
Coverity reported: CID 1611806: Concurrent data access violations (BAD_CHECK_OF_WAIT_COND) A wait is performed without a loop. If there is a spurious wakeup, the condition may not be satisfied. Fix this by checking ->state for VFIO_PROXY_CLOSED in a loop. Resolves: Coverity CID 1611806 Fixes: 0