Re: [PATCH v2 3/4] hw/adc: Add an ADC module for NPCM7XX

2020-12-14 Thread Hao Wu via
Thanks for your comment! We'll incorporate them into our next patch version. We plan to let the user use QOM get/set QMP commands to control ADC/PWM values, similar to hw/misc/tmp105.c. The user can set a voltage value as input using QOM-set, and the QEMU guest can read the converted value through

Re: [PATCH v2 3/4] hw/adc: Add an ADC module for NPCM7XX

2020-12-13 Thread Philippe Mathieu-Daudé
On 12/11/20 11:22 PM, Hao Wu via wrote: > The ADC is part of NPCM7XX Module. Its behavior is controled by the > ADC_CON register. It converts one of the eight analog inputs into a > digital input and stores it in the ADC_DATA register when enabled. > > Reviewed-by: Havard Skinnemoen > Reviewed-by

[PATCH v2 3/4] hw/adc: Add an ADC module for NPCM7XX

2020-12-11 Thread Hao Wu via
The ADC is part of NPCM7XX Module. Its behavior is controled by the ADC_CON register. It converts one of the eight analog inputs into a digital input and stores it in the ADC_DATA register when enabled. Reviewed-by: Havard Skinnemoen Reviewed-by: Tyrone Ting Signed-off-by: Hao Wu --- docs/syst