Re: [PATCH v2 3/3] vfio: Create shared routine for scanning info capabilities

2020-09-15 Thread Matthew Rosato
On 9/15/20 2:16 AM, Philippe Mathieu-Daudé wrote: On 9/15/20 12:29 AM, Matthew Rosato wrote: Rather than duplicating the same loop in multiple locations, create a static function to do the work. Why not do that first in your series? Fair question. I did originally do this collapsing first,

Re: [PATCH v2 3/3] vfio: Create shared routine for scanning info capabilities

2020-09-14 Thread Philippe Mathieu-Daudé
On 9/15/20 12:29 AM, Matthew Rosato wrote: > Rather than duplicating the same loop in multiple locations, > create a static function to do the work. Why not do that first in your series? > > Signed-off-by: Matthew Rosato > --- > hw/vfio/common.c | 33 +++-- > 1 file

[PATCH v2 3/3] vfio: Create shared routine for scanning info capabilities

2020-09-14 Thread Matthew Rosato
Rather than duplicating the same loop in multiple locations, create a static function to do the work. Signed-off-by: Matthew Rosato --- hw/vfio/common.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c ind