Re: [PATCH v2 3/3] target/riscv: update mstatus.SD when FS is set dirty

2020-01-14 Thread Richard Henderson
On 1/14/20 12:14 AM, shihpo.h...@sifive.com wrote: > tcg_gen_ori_tl(tmp, tmp, MSTATUS_FS); > +tcg_gen_ori_tl(tmp, tmp, MSTATUS_SD); Merge these: tcg_gen_ori_tl(tmp, tmp, MSTATUS_FS | MSTATUS_SD); The TCG optimizer doesn't try to handle this sort of thing. With that, Reviewed-by: Rich

[PATCH v2 3/3] target/riscv: update mstatus.SD when FS is set dirty

2020-01-14 Thread shihpo . hung
remove the check becuase SD bit should summarize FS and XS fields unconditionally. Signed-off-by: ShihPo Hung --- target/riscv/csr.c | 3 +-- target/riscv/translate.c | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index da02f9f