Re: [PATCH v2 3/3] hw/char: Extract serial-mm

2024-09-07 Thread Bernhard Beschow
Am 5. September 2024 12:26:35 UTC schrieb BALATON Zoltan : >On Thu, 5 Sep 2024, Bernhard Beschow wrote: >> hw/char/serial currently contains the implementation of both TYPE_SERIAL and >> TYPE_SERIAL_MM. According to serial_class_init(), TYPE_SERIAL is an internal >> class while TYPE_SERIAL_MM is

Re: [PATCH v2 3/3] hw/char: Extract serial-mm

2024-09-05 Thread Peter Maydell
On Thu, 5 Sept 2024 at 12:13, Philippe Mathieu-Daudé wrote: > Could we start recommend to also add SPDX tags for new files committed > to the repository? They are clearer than mis-copy/pasted license with > typos and can be parsed by tools. This is probably worth a discussion in a separate thread

Re: [PATCH v2 3/3] hw/char: Extract serial-mm

2024-09-05 Thread BALATON Zoltan
On Thu, 5 Sep 2024, Bernhard Beschow wrote: hw/char/serial currently contains the implementation of both TYPE_SERIAL and TYPE_SERIAL_MM. According to serial_class_init(), TYPE_SERIAL is an internal class while TYPE_SERIAL_MM is used by numerous machine types directly. Let's move the latter into i

Re: [PATCH v2 3/3] hw/char: Extract serial-mm

2024-09-05 Thread Philippe Mathieu-Daudé
Hi, On 5/9/24 09:38, Bernhard Beschow wrote: hw/char/serial currently contains the implementation of both TYPE_SERIAL and TYPE_SERIAL_MM. According to serial_class_init(), TYPE_SERIAL is an internal class while TYPE_SERIAL_MM is used by numerous machine types directly. Let's move the latter into

[PATCH v2 3/3] hw/char: Extract serial-mm

2024-09-05 Thread Bernhard Beschow
hw/char/serial currently contains the implementation of both TYPE_SERIAL and TYPE_SERIAL_MM. According to serial_class_init(), TYPE_SERIAL is an internal class while TYPE_SERIAL_MM is used by numerous machine types directly. Let's move the latter into its own module which makes the dependencies mor