Re: [PATCH v2 3/3] aio-posix: keep aio_notify_me disabled during polling

2020-08-06 Thread Stefan Hajnoczi
On Wed, Aug 05, 2020 at 06:37:45PM +0200, Paolo Bonzini wrote: > On 05/08/20 12:00, Stefan Hajnoczi wrote: > > + > > +/* > > + * aio_notify can avoid the expensive event_notifier_set if > > + * everything (file descriptors, bottom halves, timers) will > > + * be re-e

Re: [PATCH v2 3/3] aio-posix: keep aio_notify_me disabled during polling

2020-08-05 Thread Paolo Bonzini
On 05/08/20 12:00, Stefan Hajnoczi wrote: > + > +/* > + * aio_notify can avoid the expensive event_notifier_set if > + * everything (file descriptors, bottom halves, timers) will > + * be re-evaluated before the next blocking poll(). This is > + * already tr

[PATCH v2 3/3] aio-posix: keep aio_notify_me disabled during polling

2020-08-05 Thread Stefan Hajnoczi
Polling only monitors the ctx->notified field and does not need the ctx->notifier EventNotifier to be signalled. Keep ctx->aio_notify_me disabled while polling to avoid unnecessary EventNotifier syscalls. This optimization improves virtio-blk 4KB random read performance by 18%. The following resul