Re: [PATCH v2 26/42] semihosting: Move user-only implementation out-of-line

2025-03-31 Thread Pierrick Bouvier
On 3/18/25 14:31, Richard Henderson wrote: Avoid testing CONFIG_USER_ONLY in semihost.h. The only function that's required is semihosting_enabled. Signed-off-by: Richard Henderson This breaks bsd-user, CONFIG_SEMIHOSTING is not defined in configs/targets/*bsd-user*, thus the user stub is not

Re: [PATCH v2 26/42] semihosting: Move user-only implementation out-of-line

2025-03-20 Thread Richard Henderson
On 3/19/25 00:16, Philippe Mathieu-Daudé wrote: On 18/3/25 22:31, Richard Henderson wrote: Avoid testing CONFIG_USER_ONLY in semihost.h. The only function that's required is semihosting_enabled. Signed-off-by: Richard Henderson ---   include/semihosting/semihost.h | 29 ++--

Re: [PATCH v2 26/42] semihosting: Move user-only implementation out-of-line

2025-03-19 Thread Philippe Mathieu-Daudé
On 18/3/25 22:31, Richard Henderson wrote: Avoid testing CONFIG_USER_ONLY in semihost.h. The only function that's required is semihosting_enabled. Signed-off-by: Richard Henderson --- include/semihosting/semihost.h | 29 ++--- semihosting/user.c | 15 +

Re: [PATCH v2 26/42] semihosting: Move user-only implementation out-of-line

2025-03-18 Thread Pierrick Bouvier
On 3/18/25 14:31, Richard Henderson wrote: Avoid testing CONFIG_USER_ONLY in semihost.h. The only function that's required is semihosting_enabled. Signed-off-by: Richard Henderson --- include/semihosting/semihost.h | 29 ++--- semihosting/user.c | 15 +

[PATCH v2 26/42] semihosting: Move user-only implementation out-of-line

2025-03-18 Thread Richard Henderson
Avoid testing CONFIG_USER_ONLY in semihost.h. The only function that's required is semihosting_enabled. Signed-off-by: Richard Henderson --- include/semihosting/semihost.h | 29 ++--- semihosting/user.c | 15 +++ semihosting/meson.build| 2