Re: [PATCH v2 2/6] python/machine: close sock_pair in cleanup path

2023-07-26 Thread Ani Sinha
> On 25-Jul-2023, at 11:48 PM, Daniel P. Berrangé wrote: > > On Tue, Jul 25, 2023 at 02:03:33PM -0400, John Snow wrote: >> If everything has gone smoothly, we'll already have closed the socket we >> gave to the child during post_launch. The other half of the pair that we >> gave to the QMP con

Re: [PATCH v2 2/6] python/machine: close sock_pair in cleanup path

2023-07-25 Thread Daniel P . Berrangé
On Tue, Jul 25, 2023 at 02:03:33PM -0400, John Snow wrote: > If everything has gone smoothly, we'll already have closed the socket we > gave to the child during post_launch. The other half of the pair that we > gave to the QMP connection should, likewise, be definitively closed by > now. > > Howev

[PATCH v2 2/6] python/machine: close sock_pair in cleanup path

2023-07-25 Thread John Snow
If everything has gone smoothly, we'll already have closed the socket we gave to the child during post_launch. The other half of the pair that we gave to the QMP connection should, likewise, be definitively closed by now. However, in the cleanup path, it's possible we've created the socketpair but