Re: [PATCH v2 2/6] blockdev: Split off basic bitmap operations for qemu-img

2020-05-08 Thread Eric Blake
On 5/8/20 6:37 AM, Kevin Wolf wrote: --- Makefile.objs | 2 +- include/sysemu/blockdev.h | 14 ++ blockbitmaps.c| 324 ++ Hm. Can we get a better name? blockdev-bitmaps.c, for example? Sure, I'm open to bike-shed suggesti

Re: [PATCH v2 2/6] blockdev: Split off basic bitmap operations for qemu-img

2020-05-08 Thread Kevin Wolf
Am 30.04.2020 um 16:50 hat Eric Blake geschrieben: > On 4/30/20 8:59 AM, Max Reitz wrote: > > On 21.04.20 23:20, Eric Blake wrote: > > > Upcoming patches want to add some basic bitmap manipulation abilities > > > to qemu-img. But blockdev.o is too heavyweight to link into qemu-img > > > (among oth

Re: [PATCH v2 2/6] blockdev: Split off basic bitmap operations for qemu-img

2020-04-30 Thread Eric Blake
On 4/30/20 8:59 AM, Max Reitz wrote: On 21.04.20 23:20, Eric Blake wrote: Upcoming patches want to add some basic bitmap manipulation abilities to qemu-img. But blockdev.o is too heavyweight to link into qemu-img (among other things, it would drag in block jobs and transaction support - qemu-im

Re: [PATCH v2 2/6] blockdev: Split off basic bitmap operations for qemu-img

2020-04-30 Thread Max Reitz
On 21.04.20 23:20, Eric Blake wrote: > Upcoming patches want to add some basic bitmap manipulation abilities > to qemu-img. But blockdev.o is too heavyweight to link into qemu-img > (among other things, it would drag in block jobs and transaction > support - qemu-img does offline manipulation, whe

[PATCH v2 2/6] blockdev: Split off basic bitmap operations for qemu-img

2020-04-21 Thread Eric Blake
Upcoming patches want to add some basic bitmap manipulation abilities to qemu-img. But blockdev.o is too heavyweight to link into qemu-img (among other things, it would drag in block jobs and transaction support - qemu-img does offline manipulation, where atomicity is less important because there