Re: [PATCH v2 2/5] linux-user: Move tswap_siginfo out of target code

2024-03-07 Thread Richard Henderson
On 3/7/24 09:21, Alex Bennée wrote: +/* + * Writes out siginfo values byteswapped, accordingly to the target. It also + * cleans the si_type from si_code making it correct for the target. + */ +tswap_siginfo(&k->info, &k->info); + I'm not sure I like this, you have the same

Re: [PATCH v2 2/5] linux-user: Move tswap_siginfo out of target code

2024-03-07 Thread Richard Henderson
On 3/7/24 08:26, Gustavo Romero wrote: Move tswap_siginfo from target code to handle_pending_signal. This will allow some cleanups and having the siginfo ready to be used in gdbstub. Signed-off-by: Gustavo Romero Suggested-by: Richard Henderson --- linux-user/aarch64/signal.c | 2 +- lin

Re: [PATCH v2 2/5] linux-user: Move tswap_siginfo out of target code

2024-03-07 Thread Alex Bennée
Gustavo Romero writes: > Move tswap_siginfo from target code to handle_pending_signal. This will > allow some cleanups and having the siginfo ready to be used in gdbstub. > > Signed-off-by: Gustavo Romero > Suggested-by: Richard Henderson > --- > linux-user/aarch64/signal.c | 2 +- > linu

[PATCH v2 2/5] linux-user: Move tswap_siginfo out of target code

2024-03-07 Thread Gustavo Romero
Move tswap_siginfo from target code to handle_pending_signal. This will allow some cleanups and having the siginfo ready to be used in gdbstub. Signed-off-by: Gustavo Romero Suggested-by: Richard Henderson --- linux-user/aarch64/signal.c | 2 +- linux-user/alpha/signal.c | 2 +- lin