Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-19 Thread Gerd Hoffmann
Hi, > Hmm, ok ... but maybe I should call the new enum HotKeyMod instead of > GrabMod to make it more obvious that it is something different? Looks good to me. take care, Gerd

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-19 Thread Thomas Huth
On 19/05/2022 12.48, Gerd Hoffmann wrote: Hi, Oh well, I just noticed that we already have a GrabToggleKeys enum in qapi/common.json ... I wonder whether I should try to use that instead? It seems to be used in a slightly different context, though, if I get that right ...? qemu/ui/input-li

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-19 Thread Gerd Hoffmann
Hi, > Oh well, I just noticed that we already have a GrabToggleKeys enum in > qapi/common.json ... I wonder whether I should try to use that instead? It > seems to be used in a slightly different context, though, if I get that > right ...? qemu/ui/input-linux.c Those switch the input routing b

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-19 Thread Thomas Huth
On 19/05/2022 09.51, Daniel P. Berrangé wrote: On Thu, May 19, 2022 at 09:27:08AM +0200, Thomas Huth wrote: On 19/05/2022 09.08, Thomas Huth wrote: On 19/05/2022 08.39, Thomas Huth wrote: On 18/05/2022 17.08, Markus Armbruster wrote: Thomas Huth writes: The "-display sdl" option still uses

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-19 Thread Thomas Huth
On 19/05/2022 10.57, Markus Armbruster wrote: Daniel P. Berrangé writes: On Thu, May 19, 2022 at 09:27:08AM +0200, Thomas Huth wrote: On 19/05/2022 09.08, Thomas Huth wrote: On 19/05/2022 08.39, Thomas Huth wrote: On 18/05/2022 17.08, Markus Armbruster wrote: Thomas Huth writes: The "-d

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-19 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, May 19, 2022 at 09:27:08AM +0200, Thomas Huth wrote: >> On 19/05/2022 09.08, Thomas Huth wrote: >> > On 19/05/2022 08.39, Thomas Huth wrote: >> > > On 18/05/2022 17.08, Markus Armbruster wrote: >> > > > Thomas Huth writes: >> > > > >> > > > > The "-display s

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-19 Thread Daniel P . Berrangé
On Thu, May 19, 2022 at 09:27:08AM +0200, Thomas Huth wrote: > On 19/05/2022 09.08, Thomas Huth wrote: > > On 19/05/2022 08.39, Thomas Huth wrote: > > > On 18/05/2022 17.08, Markus Armbruster wrote: > > > > Thomas Huth writes: > > > > > > > > > The "-display sdl" option still uses a hand-crafted

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-19 Thread Markus Armbruster
Thomas Huth writes: > On 18/05/2022 17.08, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> The "-display sdl" option still uses a hand-crafted parser for its >>> parameters since we didn't want to drag an interface we considered >>> somewhat flawed into the QAPI schema. Since the flaws a

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-19 Thread Thomas Huth
On 19/05/2022 09.08, Thomas Huth wrote: On 19/05/2022 08.39, Thomas Huth wrote: On 18/05/2022 17.08, Markus Armbruster wrote: Thomas Huth writes: The "-display sdl" option still uses a hand-crafted parser for its parameters since we didn't want to drag an interface we considered somewhat fla

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-19 Thread Thomas Huth
On 19/05/2022 08.39, Thomas Huth wrote: On 18/05/2022 17.08, Markus Armbruster wrote: Thomas Huth writes: The "-display sdl" option still uses a hand-crafted parser for its parameters since we didn't want to drag an interface we considered somewhat flawed into the QAPI schema. Since the flaws

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-18 Thread Thomas Huth
On 18/05/2022 17.41, Eric Blake wrote: On Wed, May 18, 2022 at 03:44:45PM +0200, Thomas Huth wrote: The "-display sdl" option still uses a hand-crafted parser for its parameters since we didn't want to drag an interface we considered somewhat flawed into the QAPI schema. Since the flaws are gone

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-18 Thread Thomas Huth
On 18/05/2022 17.08, Markus Armbruster wrote: Thomas Huth writes: The "-display sdl" option still uses a hand-crafted parser for its parameters since we didn't want to drag an interface we considered somewhat flawed into the QAPI schema. Since the flaws are gone now, it's time to QAPIfy. This

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-18 Thread Eric Blake
On Wed, May 18, 2022 at 03:44:45PM +0200, Thomas Huth wrote: > The "-display sdl" option still uses a hand-crafted parser for its > parameters since we didn't want to drag an interface we considered > somewhat flawed into the QAPI schema. Since the flaws are gone now, > it's time to QAPIfy. > > Th

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-18 Thread Markus Armbruster
Thomas Huth writes: > The "-display sdl" option still uses a hand-crafted parser for its > parameters since we didn't want to drag an interface we considered > somewhat flawed into the QAPI schema. Since the flaws are gone now, > it's time to QAPIfy. > > This introduces the new "DisplaySDL" QAPI

[PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-18 Thread Thomas Huth
The "-display sdl" option still uses a hand-crafted parser for its parameters since we didn't want to drag an interface we considered somewhat flawed into the QAPI schema. Since the flaws are gone now, it's time to QAPIfy. This introduces the new "DisplaySDL" QAPI struct that is used to hold the p