Re: [PATCH v2 2/3] migration: Add canary to VMSTATE_END_OF_LIST

2022-01-14 Thread Philippe Mathieu-Daudé via
On 14/1/22 12:32, Philippe Mathieu-Daudé wrote: On 13/1/22 20:44, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" We fairly regularly forget VMSTATE_END_OF_LIST markers off descriptions; given that the current check is only for ->name being NULL, sometimes we get unlucky and

Re: [PATCH v2 2/3] migration: Add canary to VMSTATE_END_OF_LIST

2022-01-14 Thread Philippe Mathieu-Daudé via
On 13/1/22 20:44, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" We fairly regularly forget VMSTATE_END_OF_LIST markers off descriptions; given that the current check is only for ->name being NULL, sometimes we get unlucky and the code apparently works and no one spots the e

Re: [PATCH v2 2/3] migration: Add canary to VMSTATE_END_OF_LIST

2022-01-13 Thread Peter Maydell
On Thu, 13 Jan 2022 at 19:45, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > We fairly regularly forget VMSTATE_END_OF_LIST markers off descriptions; > given that the current check is only for ->name being NULL, sometimes > we get unlucky and the code apparently works

[PATCH v2 2/3] migration: Add canary to VMSTATE_END_OF_LIST

2022-01-13 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We fairly regularly forget VMSTATE_END_OF_LIST markers off descriptions; given that the current check is only for ->name being NULL, sometimes we get unlucky and the code apparently works and no one spots the error. Explicitly add a flag, VMS_END that should be set