Re: [PATCH v2 2/2] qcow2: don't allow discard-no-unref when discard is not enabled

2025-02-17 Thread Jean-Louis Dupond
On 7/10/24 15:00, Hanna Czenczek wrote: On 05.06.24 15:25, Jean-Louis Dupond wrote: When discard is not set to unmap/on, we should not allow setting discard-no-unref. Is this important?  Technically, it’s an incompatible change, and would require a deprecation warning first. No it doesn't

Re: [PATCH v2 2/2] qcow2: don't allow discard-no-unref when discard is not enabled

2024-07-10 Thread Hanna Czenczek
On 05.06.24 15:25, Jean-Louis Dupond wrote: When discard is not set to unmap/on, we should not allow setting discard-no-unref. Is this important?  Technically, it’s an incompatible change, and would require a deprecation warning first. (I can imagine people setting this option indiscriminate

[PATCH v2 2/2] qcow2: don't allow discard-no-unref when discard is not enabled

2024-06-05 Thread Jean-Louis Dupond
When discard is not set to unmap/on, we should not allow setting discard-no-unref. Signed-off-by: Jean-Louis Dupond --- block/qcow2.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index 50354e5b98..cead5479e4 100644 --- a/block/qcow2.c +++ b/block/qcow2.