Re: [PATCH v2 2/2] qapi/block-core: derpecate some block-job- APIs

2025-04-08 Thread Markus Armbruster
Typo in subject, make it "deprecate". Vladimir Sementsov-Ogievskiy writes: > For change, pause, resume, complete, dismiss and finalize actions > corresponding job- and block-job commands are almost equal. The > difference is in find_block_job_locked() vs find_job_locked() > functions. What's dif

Re: [PATCH v2 2/2] qapi/block-core: derpecate some block-job- APIs

2025-04-07 Thread Eric Blake
On Fri, Apr 04, 2025 at 10:31:54PM +0300, Vladimir Sementsov-Ogievskiy wrote: In the subject line: s/derpecate/deprecate/ > For change, pause, resume, complete, dismiss and finalize actions > corresponding job- and block-job commands are almost equal. The > difference is in find_block_job_locked(

[PATCH v2 2/2] qapi/block-core: derpecate some block-job- APIs

2025-04-04 Thread Vladimir Sementsov-Ogievskiy
For change, pause, resume, complete, dismiss and finalize actions corresponding job- and block-job commands are almost equal. The difference is in find_block_job_locked() vs find_job_locked() functions. What's different? 1. find_block_job_locked() do check, is found job a block-job. This OK whe