Re: [PATCH v2 2/2] char-file: add test for distinct path= and pathin=

Hi Alex, For the most part this looks fine, but I wonder if maybe there should be a couple more assertions to be certain that things are set up correctly at first, as well as maybe being sure to confirm that things weren't modified using stat(). See below... On Thursday, 2020-05-07 at 02:24:42 -

[PATCH v2 2/2] char-file: add test for distinct path= and pathin=

Signed-off-by: Alexander Bulekov --- tests/test-char.c | 83 +++ 1 file changed, 83 insertions(+) diff --git a/tests/test-char.c b/tests/test-char.c index 3afc9b1b8d..9b3e1e2a9b 100644 --- a/tests/test-char.c +++ b/tests/test-char.c @@ -1228,6 +1228,88