Re: [PATCH v2 19/29] migration/multifd: Add outgoing QIOChannelFile support

2023-10-31 Thread Peter Xu
On Mon, Oct 23, 2023 at 05:35:58PM -0300, Fabiano Rosas wrote: > Allow multifd to open file-backed channels. This will be used when > enabling the fixed-ram migration stream format which expects a > seekable transport. > > The QIOChannel read and write methods will use the preadv/pwritev > version

Re: [PATCH v2 19/29] migration/multifd: Add outgoing QIOChannelFile support

2023-10-25 Thread Daniel P . Berrangé
On Wed, Oct 25, 2023 at 12:00:12PM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Wed, Oct 25, 2023 at 11:12:38AM -0300, Fabiano Rosas wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Mon, Oct 23, 2023 at 05:35:58PM -0300, Fabiano Rosas wrote: > >> >> Allow multifd to op

Re: [PATCH v2 19/29] migration/multifd: Add outgoing QIOChannelFile support

2023-10-25 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Wed, Oct 25, 2023 at 11:12:38AM -0300, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >> > On Mon, Oct 23, 2023 at 05:35:58PM -0300, Fabiano Rosas wrote: >> >> Allow multifd to open file-backed channels. This will be used when >> >> enabling the fixed-ram

Re: [PATCH v2 19/29] migration/multifd: Add outgoing QIOChannelFile support

2023-10-25 Thread Daniel P . Berrangé
On Wed, Oct 25, 2023 at 11:12:38AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Mon, Oct 23, 2023 at 05:35:58PM -0300, Fabiano Rosas wrote: > >> Allow multifd to open file-backed channels. This will be used when > >> enabling the fixed-ram migration stream format which expect

Re: [PATCH v2 19/29] migration/multifd: Add outgoing QIOChannelFile support

2023-10-25 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Mon, Oct 23, 2023 at 05:35:58PM -0300, Fabiano Rosas wrote: >> Allow multifd to open file-backed channels. This will be used when >> enabling the fixed-ram migration stream format which expects a >> seekable transport. >> >> The QIOChannel read and write methods w

Re: [PATCH v2 19/29] migration/multifd: Add outgoing QIOChannelFile support

2023-10-25 Thread Daniel P . Berrangé
On Mon, Oct 23, 2023 at 05:35:58PM -0300, Fabiano Rosas wrote: > Allow multifd to open file-backed channels. This will be used when > enabling the fixed-ram migration stream format which expects a > seekable transport. > > The QIOChannel read and write methods will use the preadv/pwritev > version

[PATCH v2 19/29] migration/multifd: Add outgoing QIOChannelFile support

2023-10-23 Thread Fabiano Rosas
Allow multifd to open file-backed channels. This will be used when enabling the fixed-ram migration stream format which expects a seekable transport. The QIOChannel read and write methods will use the preadv/pwritev versions which don't update the file offset at each call so we can reuse the fd wi