Re: [PATCH v2 15/55] target/sparc: Remove DEBUG_UNALIGNED

2021-08-18 Thread Mark Cave-Ayland
On 03/08/2021 05:14, Richard Henderson wrote: The printf should have been qemu_log_mask, the parameters themselves no longer compile, and because this is placed before unwinding the PC is actively wrong. We get better (and correct) logging on the other side of raising the exception, in sparc_cp

[PATCH v2 15/55] target/sparc: Remove DEBUG_UNALIGNED

2021-08-02 Thread Richard Henderson
The printf should have been qemu_log_mask, the parameters themselves no longer compile, and because this is placed before unwinding the PC is actively wrong. We get better (and correct) logging on the other side of raising the exception, in sparc_cpu_do_interrupt. Cc: Mark Cave-Ayland Reviewed-b