Re: [PATCH v2 15/15] qapi: Generate simpler marshalling code when no arguments

2020-04-24 Thread Eric Blake
On 4/24/20 3:43 AM, Markus Armbruster wrote: When command FOO has no arguments, its generated qmp_marshal_FOO() is a bit confusing. Make it simpler: visit_start_struct(v, NULL, NULL, 0, &err); if (err) { goto out; } - -if (!err) { -visit_check_struct(v, &

[PATCH v2 15/15] qapi: Generate simpler marshalling code when no arguments

2020-04-24 Thread Markus Armbruster
When command FOO has no arguments, its generated qmp_marshal_FOO() is a bit confusing. Make it simpler: visit_start_struct(v, NULL, NULL, 0, &err); if (err) { goto out; } - -if (!err) { -visit_check_struct(v, &err); -} +visit_check_struct(v, &err);