Re: [PATCH v2 14/38] qapi/common.py: Convert comments into docstrings, and elaborate

2020-09-25 Thread John Snow
On 9/25/20 1:02 PM, Cleber Rosa wrote: On Wed, Sep 23, 2020 at 05:18:54PM -0400, John Snow wrote: On 9/23/20 3:38 PM, Cleber Rosa wrote: On Tue, Sep 22, 2020 at 05:00:37PM -0400, John Snow wrote: As docstrings, they'll show up in documentation and IDE help. Signed-off-by: John Snow --- sc

Re: [PATCH v2 14/38] qapi/common.py: Convert comments into docstrings, and elaborate

2020-09-25 Thread Cleber Rosa
On Wed, Sep 23, 2020 at 05:18:54PM -0400, John Snow wrote: > On 9/23/20 3:38 PM, Cleber Rosa wrote: > > On Tue, Sep 22, 2020 at 05:00:37PM -0400, John Snow wrote: > > > As docstrings, they'll show up in documentation and IDE help. > > > > > > Signed-off-by: John Snow > > > --- > > > scripts/qap

Re: [PATCH v2 14/38] qapi/common.py: Convert comments into docstrings, and elaborate

2020-09-23 Thread John Snow
On 9/23/20 3:38 PM, Cleber Rosa wrote: On Tue, Sep 22, 2020 at 05:00:37PM -0400, John Snow wrote: As docstrings, they'll show up in documentation and IDE help. Signed-off-by: John Snow --- scripts/qapi/common.py | 51 ++ 1 file changed, 37 insertions(

Re: [PATCH v2 14/38] qapi/common.py: Convert comments into docstrings, and elaborate

2020-09-23 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:00:37PM -0400, John Snow wrote: > As docstrings, they'll show up in documentation and IDE help. > > Signed-off-by: John Snow > --- > scripts/qapi/common.py | 51 ++ > 1 file changed, 37 insertions(+), 14 deletions(-) > > diff --

Re: [PATCH v2 14/38] qapi/common.py: Convert comments into docstrings, and elaborate

2020-09-23 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:00:37PM -0400, John Snow wrote: > As docstrings, they'll show up in documentation and IDE help. > > Signed-off-by: John Snow Reviewed-by: Eduardo Habkost -- Eduardo

[PATCH v2 14/38] qapi/common.py: Convert comments into docstrings, and elaborate

2020-09-22 Thread John Snow
As docstrings, they'll show up in documentation and IDE help. Signed-off-by: John Snow --- scripts/qapi/common.py | 51 ++ 1 file changed, 37 insertions(+), 14 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index 0ce4a107e6..730