Re: [PATCH v2 12/33] block/copy-before-write: drop extra bdrv_unref on failure path

2021-05-31 Thread Max Reitz
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: bdrv_attach_child() do bdrv_unref() on failure, so we shouldn't do it by hand here. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/copy-before-write.c | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Max Reitz

[PATCH v2 12/33] block/copy-before-write: drop extra bdrv_unref on failure path

2021-05-20 Thread Vladimir Sementsov-Ogievskiy
bdrv_attach_child() do bdrv_unref() on failure, so we shouldn't do it by hand here. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/copy-before-write.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/copy-before-write.c b/block/copy-before-write.c index 2a51cc64e4..945d9340f4 1006