Re: [PATCH v2 12/21] gdbstub: abstract target specific details from gdb_put_packet_binary

2023-01-06 Thread Richard Henderson
On 1/5/23 08:43, Alex Bennée wrote: We unfortunately handle the checking of packet acknowledgement differently for user and softmmu modes. Abstract the user mode stuff behind gdb_got_immediate_ack with a stub for softmmu. Signed-off-by: Alex Bennée --- gdbstub/internals.h | 15 +++

Re: [PATCH v2 12/21] gdbstub: abstract target specific details from gdb_put_packet_binary

2023-01-05 Thread Philippe Mathieu-Daudé
On 5/1/23 17:43, Alex Bennée wrote: We unfortunately handle the checking of packet acknowledgement differently for user and softmmu modes. Abstract the user mode stuff behind gdb_got_immediate_ack with a stub for softmmu. Signed-off-by: Alex Bennée --- gdbstub/internals.h | 15 +++

[PATCH v2 12/21] gdbstub: abstract target specific details from gdb_put_packet_binary

2023-01-05 Thread Alex Bennée
We unfortunately handle the checking of packet acknowledgement differently for user and softmmu modes. Abstract the user mode stuff behind gdb_got_immediate_ack with a stub for softmmu. Signed-off-by: Alex Bennée --- gdbstub/internals.h | 15 +++ gdbstub/gdbstub.c | 10 ++