Re: [PATCH v2 11/17] python/machine: remove has_quit argument

2021-10-12 Thread Hanna Reitz
On 23.09.21 02:49, John Snow wrote: If we spy on the QMP commands instead, we don't need callers to remember to pass it. Seems like a fair trade-off. The one slightly weird bit is overloading this instance variable for wait(), where we use it to mean "don't issue the qmp 'quit' command". This me

[PATCH v2 11/17] python/machine: remove has_quit argument

2021-09-22 Thread John Snow
If we spy on the QMP commands instead, we don't need callers to remember to pass it. Seems like a fair trade-off. The one slightly weird bit is overloading this instance variable for wait(), where we use it to mean "don't issue the qmp 'quit' command". This means that wait() will "fail" if the QEM