Re: [PATCH v2 11/12] gdbstub: replace global gdb_has_xml with a function

2023-08-25 Thread Philippe Mathieu-Daudé
On 24/8/23 18:39, Alex Bennée wrote: Try and make the self reported global hack a little less hackish by providing a query function instead. As gdb_has_xml was always set if we negotiated XML we can now use the presence of ->target_xml as the test instead. Signed-off-by: Alex Bennée --- gdbst

Re: [PATCH v2 11/12] gdbstub: replace global gdb_has_xml with a function

2023-08-24 Thread Richard Henderson
On 8/24/23 09:39, Alex Bennée wrote: Try and make the self reported global hack a little less hackish by providing a query function instead. As gdb_has_xml was always set if we negotiated XML we can now use the presence of ->target_xml as the test instead. Signed-off-by: Alex Bennée --- gdbstu

[PATCH v2 11/12] gdbstub: replace global gdb_has_xml with a function

2023-08-24 Thread Alex Bennée
Try and make the self reported global hack a little less hackish by providing a query function instead. As gdb_has_xml was always set if we negotiated XML we can now use the presence of ->target_xml as the test instead. Signed-off-by: Alex Bennée --- gdbstub/internals.h| 1 + include/exec/g