Re: [PATCH v2 10/12] gdbstub: refactor get_feature_xml

2023-08-29 Thread Alex Bennée
Richard Henderson writes: > On 8/24/23 09:39, Alex Bennée wrote: >> Try to bring up the code to more modern standards by: >>- use dynamic GString built xml over a fixed buffer >>- use autofree to save on explicit g_free() calls >>- don't hand hack strstr to find the delimiter >> Sig

Re: [PATCH v2 10/12] gdbstub: refactor get_feature_xml

2023-08-24 Thread Richard Henderson
On 8/24/23 09:39, Alex Bennée wrote: Try to bring up the code to more modern standards by: - use dynamic GString built xml over a fixed buffer - use autofree to save on explicit g_free() calls - don't hand hack strstr to find the delimiter Signed-off-by: Alex Bennée --- v2 - avoid

[PATCH v2 10/12] gdbstub: refactor get_feature_xml

2023-08-24 Thread Alex Bennée
Try to bring up the code to more modern standards by: - use dynamic GString built xml over a fixed buffer - use autofree to save on explicit g_free() calls - don't hand hack strstr to find the delimiter Signed-off-by: Alex Bennée --- v2 - avoid needless g_strndup for copy of annex ---