Re: [PATCH v2 10/11] qapi/introspect.py: improve readability of _tree_to_qlit

2020-12-15 Thread John Snow
On 11/16/20 5:17 AM, Markus Armbruster wrote: John Snow writes: Subjective, but I find getting rid of the comprehensions helps. Also, divide the sections into scalar and non-scalar sections, and remove old-style string formatting. Signed-off-by: John Snow --- scripts/qapi/introspect.py | 3

Re: [PATCH v2 10/11] qapi/introspect.py: improve readability of _tree_to_qlit

2020-11-16 Thread Markus Armbruster
John Snow writes: > Subjective, but I find getting rid of the comprehensions helps. Also, > divide the sections into scalar and non-scalar sections, and remove > old-style string formatting. > > Signed-off-by: John Snow > --- > scripts/qapi/introspect.py | 37 +--

Re: [PATCH v2 10/11] qapi/introspect.py: improve readability of _tree_to_qlit

2020-11-06 Thread Cleber Rosa
On Mon, Oct 26, 2020 at 03:42:50PM -0400, John Snow wrote: > Subjective, but I find getting rid of the comprehensions helps. Also, > divide the sections into scalar and non-scalar sections, and remove > old-style string formatting. > It's certainly a matter of picking your favorite poison... but f

[PATCH v2 10/11] qapi/introspect.py: improve readability of _tree_to_qlit

2020-10-26 Thread John Snow
Subjective, but I find getting rid of the comprehensions helps. Also, divide the sections into scalar and non-scalar sections, and remove old-style string formatting. Signed-off-by: John Snow --- scripts/qapi/introspect.py | 37 + 1 file changed, 21 insertions