Re: [PATCH v2 1/8] migration: Do not use C99 // comments

2020-10-13 Thread Bihong Yu
OK, I will modify it later. On 2020/10/14 9:29, Zheng Chuan wrote: > Also DEBUG_CACHE in migration/page_cache.c is need to rebase on trace_calls. > > On 2020/10/13 21:20, Bihong Yu wrote: >> Thank you for your review. OK, I will try to rewrite the DPRINTF to use >> trace_ instead. >> >> On 2020/

Re: [PATCH v2 1/8] migration: Do not use C99 // comments

2020-10-13 Thread Zheng Chuan
Also DEBUG_CACHE in migration/page_cache.c is need to rebase on trace_calls. On 2020/10/13 21:20, Bihong Yu wrote: > Thank you for your review. OK, I will try to rewrite the DPRINTF to use > trace_ instead. > > On 2020/10/13 17:39, Dr. David Alan Gilbert wrote: >> * Bihong Yu (yubih...@huawei.co

Re: [PATCH v2 1/8] migration: Do not use C99 // comments

2020-10-13 Thread Bihong Yu
Thank you for your review. OK, I will try to rewrite the DPRINTF to use trace_ instead. On 2020/10/13 17:39, Dr. David Alan Gilbert wrote: > * Bihong Yu (yubih...@huawei.com) wrote: >> Signed-off-by: Bihong Yu >> Reviewed-by: Chuan Zheng > > Reviewed-by: Dr. David Alan Gilbert > > another ta

Re: [PATCH v2 1/8] migration: Do not use C99 // comments

2020-10-13 Thread Dr. David Alan Gilbert
* Bihong Yu (yubih...@huawei.com) wrote: > Signed-off-by: Bihong Yu > Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert another task at some point would be to rewrite the DPRINTF's in migration/block.c to use trace_ instead. > --- > migration/block.c | 2 +- > migration/rdma.c |

[PATCH v2 1/8] migration: Do not use C99 // comments

2020-10-12 Thread Bihong Yu
Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng --- migration/block.c | 2 +- migration/rdma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/block.c b/migration/block.c index 737b649..4b8576b 100644 --- a/migration/block.c +++ b/migration/block.c @@ -40,7 +4