Re: [PATCH v2 1/7] vhost: recheck dev state in the vhost_migration_log routine

2020-08-31 Thread Dima Stepanov
On Thu, Aug 27, 2020 at 09:44:22PM -0400, Raphael Norwitz wrote: > Generally I’m happy with this. Some comments: > > On Mon, Aug 24, 2020 at 4:40 AM Dima Stepanov wrote: > > > > vhost-user devices can get a disconnect in the middle of the VHOST-USER > > handshake on the migration start. If discon

Re: [PATCH v2 1/7] vhost: recheck dev state in the vhost_migration_log routine

2020-08-27 Thread Raphael Norwitz
Generally I’m happy with this. Some comments: On Mon, Aug 24, 2020 at 4:40 AM Dima Stepanov wrote: > > vhost-user devices can get a disconnect in the middle of the VHOST-USER > handshake on the migration start. If disconnect event happened right > before sending next VHOST-USER command, then the

[PATCH v2 1/7] vhost: recheck dev state in the vhost_migration_log routine

2020-08-24 Thread Dima Stepanov
vhost-user devices can get a disconnect in the middle of the VHOST-USER handshake on the migration start. If disconnect event happened right before sending next VHOST-USER command, then the vhost_dev_set_log() call in the vhost_migration_log() function will return error. This error will lead to the