Re: [PATCH v2 1/6] migration: All this fields are unsigned

2021-12-24 Thread Juan Quintela
Peter Xu wrote: > On Tue, Dec 21, 2021 at 01:52:30PM +0100, Juan Quintela wrote: >> So printing it as %d is wrong. Notice that for the channel id, that >> is an uint8_t, but I changed it anyways for consistency. > > Just curious: uint_8 can always correctly converted to a int, so the patch > shou

Re: [PATCH v2 1/6] migration: All this fields are unsigned

2021-12-23 Thread Peter Xu
On Tue, Dec 21, 2021 at 01:52:30PM +0100, Juan Quintela wrote: > So printing it as %d is wrong. Notice that for the channel id, that > is an uint8_t, but I changed it anyways for consistency. Just curious: uint_8 can always correctly converted to a int, so the patch shouldn't have a functional ch

[PATCH v2 1/6] migration: All this fields are unsigned

2021-12-21 Thread Juan Quintela
So printing it as %d is wrong. Notice that for the channel id, that is an uint8_t, but I changed it anyways for consistency. Signed-off-by: Juan Quintela Reviewed-by: Philippe Mathieu-Daudé --- migration/multifd-zlib.c | 20 ++-- migration/multifd-zstd.c | 24 --