Re: [PATCH v2 1/3] win32: remove usage of attribute gcc_struct

2024-11-27 Thread Pierrick Bouvier
On 11/27/24 01:20, Stefano Garzarella wrote: On Tue, Nov 26, 2024 at 01:17:34PM -0800, Pierrick Bouvier wrote: This attribute is not recognized by clang. An investigation has been performed to ensure this attribute has no effect on layout of structures we use in QEMU [1], so it's safe to remove

Re: [PATCH v2 1/3] win32: remove usage of attribute gcc_struct

2024-11-27 Thread Stefano Garzarella
On Tue, Nov 26, 2024 at 01:17:34PM -0800, Pierrick Bouvier wrote: This attribute is not recognized by clang. An investigation has been performed to ensure this attribute has no effect on layout of structures we use in QEMU [1], so it's safe to remove now. In the future, we'll forbid introducing

Re: [PATCH v2 1/3] win32: remove usage of attribute gcc_struct

2024-11-26 Thread Thomas Huth
On 26/11/2024 22.17, Pierrick Bouvier wrote: This attribute is not recognized by clang. An investigation has been performed to ensure this attribute has no effect on layout of structures we use in QEMU [1], so it's safe to remove now. In the future, we'll forbid introducing new bitfields in pac

[PATCH v2 1/3] win32: remove usage of attribute gcc_struct

2024-11-26 Thread Pierrick Bouvier
This attribute is not recognized by clang. An investigation has been performed to ensure this attribute has no effect on layout of structures we use in QEMU [1], so it's safe to remove now. In the future, we'll forbid introducing new bitfields in packed struct. [1] https://lore.kernel.org/qemu-